From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v1 6/8] vmw_balloon: mark inflated pages PG_offline To: Nadav Amit Cc: linux-mm , Linux Kernel Mailing List , "open list:DOCUMENTATION" , "devel@linuxdriverproject.org" , linux-fsdevel , "linux-pm@vger.kernel.org" , xen-devel , kexec-ml , pv-drivers , Xavier Deguillard , Arnd Bergmann , Greg Kroah-Hartman , Julien Freche , Andrew Morton , Matthew Wilcox , Michal Hocko , "Michael S. Tsirkin" References: <20181119101616.8901-1-david@redhat.com> <20181119101616.8901-7-david@redhat.com> <9F78496F-EBAE-4248-80F0-0CB55CEFA238@vmware.com> From: David Hildenbrand Message-ID: Date: Wed, 21 Nov 2018 09:54:29 +0100 MIME-Version: 1.0 In-Reply-To: <9F78496F-EBAE-4248-80F0-0CB55CEFA238@vmware.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On 21.11.18 04:22, Nadav Amit wrote: > Thanks for this patch! > >> On Nov 19, 2018, at 2:16 AM, David Hildenbrand wrote: >> >> Mark inflated and never onlined pages PG_offline, to tell the world that >> the content is stale and should not be dumped. >> >> Cc: Xavier Deguillard >> Cc: Nadav Amit >> Cc: Arnd Bergmann >> Cc: Greg Kroah-Hartman >> Cc: Julien Freche >> Cc: Andrew Morton >> Cc: Matthew Wilcox >> Cc: Michal Hocko >> Cc: "Michael S. Tsirkin" >> Signed-off-by: David Hildenbrand >> --- >> drivers/misc/vmw_balloon.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c >> index e6126a4b95d3..8cc8bd9a4e32 100644 >> --- a/drivers/misc/vmw_balloon.c >> +++ b/drivers/misc/vmw_balloon.c >> @@ -544,6 +544,36 @@ unsigned int vmballoon_page_order(enum vmballoon_page_size_type page_size) >> return page_size == VMW_BALLOON_2M_PAGE ? VMW_BALLOON_2M_ORDER : 0; >> } >> >> +/** >> + * vmballoon_mark_page_offline() - mark a page as offline >> + * @page: pointer for the page > > If possible, please add a period at the end of the sentence (yes, I know I > got it wrong in some places too). Sure :) > >> + * @page_size: the size of the page. >> + */ >> +static void >> +vmballoon_mark_page_offline(struct page *page, >> + enum vmballoon_page_size_type page_size) >> +{ >> + int i; >> + >> + for (i = 0; i < 1ULL << vmballoon_page_order(page_size); i++) > > Can you please do instead: > > unsigned int; > > for (i = 0; i < vmballoon_page_in_frames(page_size); i++) > Will do, will have to move both functions a little bit down in the file (exactly one function). > We would like to test it in the next few days, but in the meanwhile, after > you address these minor issues: > > Acked-by: Nadav Amit Thanks! > > Thanks again, > Nadav > -- Thanks, David / dhildenb