* Re: [PATCH] iomap: directly use logical block size
2022-10-26 16:51 [PATCH] iomap: directly use logical block size Keith Busch
@ 2022-10-26 18:06 ` Chaitanya Kulkarni
2022-10-26 18:33 ` Darrick J. Wong
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2022-10-26 18:06 UTC (permalink / raw)
To: Keith Busch, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hch@lst.de, djwong@kernel.org,
bvanassche@acm.org, Keith Busch
On 10/26/2022 9:51 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
we should also change any other callers like this.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iomap: directly use logical block size
2022-10-26 16:51 [PATCH] iomap: directly use logical block size Keith Busch
2022-10-26 18:06 ` Chaitanya Kulkarni
@ 2022-10-26 18:33 ` Darrick J. Wong
2022-10-28 21:41 ` Bart Van Assche
2022-10-30 8:27 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Darrick J. Wong @ 2022-10-26 18:33 UTC (permalink / raw)
To: Keith Busch; +Cc: linux-fsdevel, linux-kernel, hch, bvanassche, Keith Busch
On Wed, Oct 26, 2022 at 09:51:33AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> fs/iomap/direct-io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 4eb559a16c9e..503b97e5a115 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -240,7 +240,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
> {
> const struct iomap *iomap = &iter->iomap;
> struct inode *inode = iter->inode;
> - unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev));
> + unsigned int blksz = bdev_logical_block_size(iomap->bdev);
/me looks at what blksize_bits does (assumes block size > 256) and rolls
his eyes.
Regardless, this looks correct to me, so
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> unsigned int fs_block_size = i_blocksize(inode), pad;
> loff_t length = iomap_length(iter);
> loff_t pos = iter->pos;
> @@ -252,7 +252,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
> size_t copied = 0;
> size_t orig_count;
>
> - if ((pos | length) & ((1 << blkbits) - 1) ||
> + if ((pos | length) & (blksz - 1) ||
> !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter))
> return -EINVAL;
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iomap: directly use logical block size
2022-10-26 16:51 [PATCH] iomap: directly use logical block size Keith Busch
2022-10-26 18:06 ` Chaitanya Kulkarni
2022-10-26 18:33 ` Darrick J. Wong
@ 2022-10-28 21:41 ` Bart Van Assche
2022-10-30 8:27 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2022-10-28 21:41 UTC (permalink / raw)
To: Keith Busch, linux-fsdevel; +Cc: linux-kernel, hch, djwong, Keith Busch
On 10/26/22 09:51, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---
> fs/iomap/direct-io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 4eb559a16c9e..503b97e5a115 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -240,7 +240,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
> {
> const struct iomap *iomap = &iter->iomap;
> struct inode *inode = iter->inode;
> - unsigned int blkbits = blksize_bits(bdev_logical_block_size(iomap->bdev));
> + unsigned int blksz = bdev_logical_block_size(iomap->bdev);
> unsigned int fs_block_size = i_blocksize(inode), pad;
> loff_t length = iomap_length(iter);
> loff_t pos = iter->pos;
> @@ -252,7 +252,7 @@ static loff_t iomap_dio_bio_iter(const struct iomap_iter *iter,
> size_t copied = 0;
> size_t orig_count;
>
> - if ((pos | length) & ((1 << blkbits) - 1) ||
> + if ((pos | length) & (blksz - 1) ||
> !bdev_iter_is_aligned(iomap->bdev, dio->submit.iter))
> return -EINVAL;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iomap: directly use logical block size
2022-10-26 16:51 [PATCH] iomap: directly use logical block size Keith Busch
` (2 preceding siblings ...)
2022-10-28 21:41 ` Bart Van Assche
@ 2022-10-30 8:27 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2022-10-30 8:27 UTC (permalink / raw)
To: Keith Busch
Cc: linux-fsdevel, linux-kernel, hch, djwong, bvanassche, Keith Busch
On Wed, Oct 26, 2022 at 09:51:33AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
This looks reasonable. But given that the blksz variable is only used
once, why not open code the bdev_logical_block_size in the conditional?
^ permalink raw reply [flat|nested] 5+ messages in thread