From: "Bob Copeland" <me@bobcopeland.com>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/7] omfs: add bitmap routines
Date: Fri, 28 Mar 2008 09:26:19 -0400 [thread overview]
Message-ID: <b6c5339f0803280626p221872b6t15f9b6fc9bc480f3@mail.gmail.com> (raw)
In-Reply-To: <200803280451.11216.arnd@arndb.de>
On Thu, Mar 27, 2008 at 11:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 27 March 2008, Bob Copeland wrote:
>
> > +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0};
> > +
> > +unsigned long omfs_count_free(struct super_block *sb)
>
> I think it would be helpful to express this using hweight64.
Thanks for the review.
Yes, that would probably be cleaner. FWIW minix and affs both have
this sort of code too.
-Bob
next prev parent reply other threads:[~2008-03-28 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 0:45 [PATCH 5/7] omfs: add bitmap routines Bob Copeland
2008-03-28 3:51 ` Arnd Bergmann
2008-03-28 13:26 ` Bob Copeland [this message]
2008-03-30 3:27 ` Bob Copeland
-- strict thread matches above, loose matches on Subject: below --
2008-04-12 22:58 Bob Copeland
2008-04-13 8:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c5339f0803280626p221872b6t15f9b6fc9bc480f3@mail.gmail.com \
--to=me@bobcopeland.com \
--cc=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).