From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bob Copeland" Subject: Re: [PATCH 5/7] omfs: add bitmap routines Date: Fri, 28 Mar 2008 09:26:19 -0400 Message-ID: References: <1206578760-9050-5-git-send-email-me@bobcopeland.com> <200803280451.11216.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "Arnd Bergmann" Return-path: Received: from wa-out-1112.google.com ([209.85.146.177]:10890 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbYC1N0U (ORCPT ); Fri, 28 Mar 2008 09:26:20 -0400 Received: by wa-out-1112.google.com with SMTP id v27so305712wah.23 for ; Fri, 28 Mar 2008 06:26:19 -0700 (PDT) In-Reply-To: <200803280451.11216.arnd@arndb.de> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 27, 2008 at 11:51 PM, Arnd Bergmann wrote: > On Thursday 27 March 2008, Bob Copeland wrote: > > > +static int nibblemap[] = {4, 3, 3, 2, 3, 2, 2, 1, 3, 2, 2, 1, 2, 1, 1, 0}; > > + > > +unsigned long omfs_count_free(struct super_block *sb) > > I think it would be helpful to express this using hweight64. Thanks for the review. Yes, that would probably be cleaner. FWIW minix and affs both have this sort of code too. -Bob