From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bob Copeland" Subject: Re: [PATCH 2/7] omfs: add inode routines Date: Fri, 28 Mar 2008 09:34:56 -0400 Message-ID: References: <1206578760-9050-2-git-send-email-me@bobcopeland.com> <200803280442.45974.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "Arnd Bergmann" Return-path: Received: from rn-out-0910.google.com ([64.233.170.190]:40231 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbYC1NfQ (ORCPT ); Fri, 28 Mar 2008 09:35:16 -0400 Received: by rn-out-0910.google.com with SMTP id e24so67480rng.1 for ; Fri, 28 Mar 2008 06:35:15 -0700 (PDT) In-Reply-To: <200803280442.45974.arnd@arndb.de> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 27, 2008 at 11:42 PM, Arnd Bergmann wrote: > On Thursday 27 March 2008, Bob Copeland wrote: > If you could avoid the i_state member in omfs_inode_info, you could get > rid of your own inode cache entirely. Your i_state seems to be mostly > write-only, why is it needed in your file system? Err, yeah, it looks to be superfluous. I think it's a relic from when I once did an initialization in omfs_write_inode. Thanks, Bob