Re: [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1451 bytes --]

Hi,

On 7/6/22 00:23, Darrick J. Wong wrote:
> On Tue, Jul 05, 2022 at 11:36:14AM -0700, Eric Biggers wrote:
>> From: Eric Biggers <ebiggers@google.com>
>>
>> Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"),
>> STATX_ALL is deprecated.  It doesn't include STATX_MNT_ID, and it won't
>> include any future flags.  Update the man page accordingly.
>>
>> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks for the patch!  Applied.
> 
> As the last idiot to trip over this,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

And thanks for the reviews, Andreas and Darrick, I added both of your tags.

Cheers,

Alex

> 
> --D
> 
>> ---
>>   man2/statx.2 | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/man2/statx.2 b/man2/statx.2
>> index a8620be6f..561e64f7b 100644
>> --- a/man2/statx.2
>> +++ b/man2/statx.2
>> @@ -244,8 +244,9 @@ STATX_SIZE	Want stx_size
>>   STATX_BLOCKS	Want stx_blocks
>>   STATX_BASIC_STATS	[All of the above]
>>   STATX_BTIME	Want stx_btime
>> +STATX_ALL	The same as STATX_BASIC_STATS | STATX_BTIME.
>> +         	This is deprecated and should not be used.
>>   STATX_MNT_ID	Want stx_mnt_id (since Linux 5.8)
>> -STATX_ALL	[All currently available fields]
>>   .TE
>>   .in
>>   .PP
>>
>> base-commit: 88646725187456fad6f17552e96c50c93bd361dc
>> -- 
>> 2.37.0
>>

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]