From: Rik van Riel <riel@fb.com>
To: Song Liu <songliubraving@fb.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "matthew.wilcox@oracle.com" <matthew.wilcox@oracle.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"Kernel Team" <Kernel-team@fb.com>,
"william.kucharski@oracle.com" <william.kucharski@oracle.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v4 5/6] mm,thp: add read-only THP support for (non-shmem) FS
Date: Thu, 20 Jun 2019 17:33:25 +0000 [thread overview]
Message-ID: <b9db545fdb5058831e48504ea4e4e0bcaaf36ff3.camel@fb.com> (raw)
In-Reply-To: <20190620172752.3300742-6-songliubraving@fb.com>
On Thu, 2019-06-20 at 10:27 -0700, Song Liu wrote:
> This patch is (hopefully) the first step to enable THP for non-shmem
> filesystems.
>
> This patch enables an application to put part of its text sections to
> THP
> via madvise, for example:
>
> madvise((void *)0x600000, 0x200000, MADV_HUGEPAGE);
>
> We tried to reuse the logic for THP on tmpfs.
>
> Currently, write is not supported for non-shmem THP. khugepaged will
> only
> process vma with VM_DENYWRITE. The next patch will handle writes,
> which
> would only happen when the vma with VM_DENYWRITE is unmapped.
>
> An EXPERIMENTAL config, READ_ONLY_THP_FOR_FS, is added to gate this
> feature.
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Rik van Riel <riel@surriel.com>
(I suppose I should have sent this out last night,
while I was posting questions about patch 6)
next prev parent reply other threads:[~2019-06-20 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 17:27 [PATCH v4 0/6] [PATCH v3 0/6] Enable THP for text section of non-shmem files Song Liu
2019-06-20 17:27 ` [PATCH v4 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Song Liu
2019-06-20 17:27 ` [PATCH v4 2/6] filemap: update offset check " Song Liu
2019-06-20 17:27 ` [PATCH v4 3/6] mm,thp: stats for file backed THP Song Liu
2019-06-20 17:27 ` [PATCH v4 4/6] khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() Song Liu
2019-06-20 17:27 ` [PATCH v4 5/6] mm,thp: add read-only THP support for (non-shmem) FS Song Liu
2019-06-20 17:33 ` Rik van Riel [this message]
2019-06-20 17:27 ` [PATCH v4 6/6] mm,thp: avoid writes to file with THP in pagecache Song Liu
2019-06-20 17:42 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9db545fdb5058831e48504ea4e4e0bcaaf36ff3.camel@fb.com \
--to=riel@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=songliubraving@fb.com \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).