From: Stefan Agner <stefan@agner.ch>
To: Amir Goldstein <amir73il@gmail.com>, Miklos Szeredi <miklos@szeredi.hu>
Cc: Sasha Levin <alexander.levin@microsoft.com>,
overlayfs <linux-unionfs@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: WARNING: possible recursive locking detected in mnt_want_write/mnt_want_write_file_path
Date: Thu, 18 Oct 2018 15:25:28 +0200 [thread overview]
Message-ID: <b9f68a97417b5d907e8e882b9e8d19a1@agner.ch> (raw)
In-Reply-To: <CAOQ4uxjqmQJmE5xLfqJGCnZoMf6NPtcNso7Fotjy_hGAUObK+w@mail.gmail.com>
On 18.10.2018 13:50, Amir Goldstein wrote:
> On Wed, Oct 17, 2018 at 9:37 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>>
>> On Wed, Oct 17, 2018 at 5:24 PM, Amir Goldstein <amir73il@gmail.com> wrote:
>
>> > Miklos,
>> >
>> > You must have confused "the algorithm" by including a "fix" commit in
>> > rc1 pull request
>> > without mentioning that it "Fixes" a commit in the same pull request.
>>
>> I didn't know there were heuristics other than "Cc: stable@.."
>>
>
> Yes. Given a Fixes: label, I bet Cc: stable is not needed to auto select
> for stable??
Given a Fixes: probably would prevented it to be selected since the
commit it references is not part of 4.18...
Anyway, as expected, reverting the commit on stable 4.18.4 fixes the
warning for me.
Thanks for tracking down!
--
Stefan
>
> Sasha,
>
> Please note that lack of Fixes: or Cc: stable from some subsystems
> is a rather strong indication for NOT for stable.
>
> I suppose that in case of stable branch regression due to incorrect
> patch selection there is a strong negative feedback to the algorithm?
>
> Thanks,
> Amir.
next prev parent reply other threads:[~2018-10-18 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 8:00 WARNING: possible recursive locking detected in mnt_want_write/mnt_want_write_file_path Stefan Agner
2018-10-17 8:29 ` Miklos Szeredi
2018-10-17 15:24 ` Amir Goldstein
2018-10-17 16:03 ` Sasha Levin
2018-10-17 18:37 ` Miklos Szeredi
2018-10-18 11:50 ` Amir Goldstein
2018-10-18 13:25 ` Stefan Agner [this message]
2018-10-18 14:34 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f68a97417b5d907e8e882b9e8d19a1@agner.ch \
--to=stefan@agner.ch \
--cc=alexander.levin@microsoft.com \
--cc=amir73il@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).