From: Randy Dunlap <rdunlap@infradead.org>
To: YANG LI <abaci-bugfix@linux.alibaba.com>, axboe@kernel.dk
Cc: viro@zeniv.linux.org.uk, io-uring@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: style: redundant NULL check.
Date: Tue, 29 Dec 2020 22:29:00 -0800 [thread overview]
Message-ID: <bb01e932-9b93-c672-2e76-d8a2918d5bd6@infradead.org> (raw)
In-Reply-To: <1609309375-65129-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On 12/29/20 10:22 PM, YANG LI wrote:
> If the pointer in kfree is empty, the function does nothing,
> so remove the redundant NULL check.
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci <abaci@linux.alibaba.com>
> ---
Looks like you should do something with these 2 comments:
/* it's reportedly faster than delegating the null check to kfree() */
> fs/io_uring.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 7e35283..105e188 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -1934,8 +1934,8 @@ static void io_dismantle_req(struct io_kiocb *req)
> {
> io_clean_op(req);
>
> - if (req->async_data)
> - kfree(req->async_data);
> + kfree(req->async_data);
> +
> if (req->file)
> io_put_file(req, req->file, (req->flags & REQ_F_FIXED_FILE));
> if (req->fixed_file_refs)
> @@ -3537,8 +3537,7 @@ static int io_read(struct io_kiocb *req, bool force_nonblock,
> ret = 0;
> out_free:
> /* it's reportedly faster than delegating the null check to kfree() */
> - if (iovec)
> - kfree(iovec);
> + kfree(iovec);
> return ret;
> }
>
> @@ -3644,8 +3643,7 @@ static int io_write(struct io_kiocb *req, bool force_nonblock,
> }
> out_free:
> /* it's reportedly faster than delegating the null check to kfree() */
> - if (iovec)
> - kfree(iovec);
> + kfree(iovec);
> return ret;
> }
>
> @@ -6133,8 +6131,7 @@ static void __io_clean_op(struct io_kiocb *req)
> case IORING_OP_WRITE_FIXED:
> case IORING_OP_WRITE: {
> struct io_async_rw *io = req->async_data;
> - if (io->free_iovec)
> - kfree(io->free_iovec);
> + kfree(io->free_iovec);
> break;
> }
> case IORING_OP_RECVMSG:
>
--
~Randy
prev parent reply other threads:[~2020-12-30 6:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 6:22 [PATCH] io_uring: style: redundant NULL check YANG LI
2020-12-30 6:29 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb01e932-9b93-c672-2e76-d8a2918d5bd6@infradead.org \
--to=rdunlap@infradead.org \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).