From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB0C5314D0C; Fri, 23 Jan 2026 00:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769128961; cv=none; b=uTNxrb1t/03f9ZtBy3bVPBtvb5X6npzet81voa4qPnJDNprXAgnomF+fh16CwhgLjenGF3SFdVMrIDuiUlC/gwwiTpB0Wl7qBjGNG4kb4X5YgZL3LmQijs6NRdKcApa/IusvqQjJYm+enoZCfTORqad6XJQ/opfSoK7PTMqU8Nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769128961; c=relaxed/simple; bh=YxGwcerMm4XsXjm+1niJ1WYBTECA2bIMf19KywNaCDg=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=X8nUQ0SKpcKOkvkkJnGibow4R7U6en93Fn2uuXx6nEVLKhDcxgYrydFjF1XFj4Bd5VYkEDkeBzrugVokNZ66E4oAjR4cbYaqAKILLnZU38r2PUXzjRDP0XUBzKfSGNPkY8cwdXOwnvRcqU3RjaJCIcHCb6BoUrXWthpPVkqVuC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ShZI1/yN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ShZI1/yN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D617C4AF09; Fri, 23 Jan 2026 00:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769128961; bh=YxGwcerMm4XsXjm+1niJ1WYBTECA2bIMf19KywNaCDg=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=ShZI1/yNzfRZmu3sAjPE26FJHVCzdjNlR+PLLp4IBIjapKolYcMC/p/AzlQi8kHOy E6N/2W2E5pbB7ftb730Cw4JH/VlIVqvxbnyT1of+3pueWWa9Uliru6CZhIiNC88aWu VqzFK4TQxalFuLYdfa7Gk1bYZr2eTNdyfe6gSwFV/oQuP8DRhWTVOPyO0H6/XntitM tBUss/brfrvJZRVZ5OZuEX1lA9AjU+iqu/0VZA+qg0XEwsarVMGki7cWdIvd9MnvDN 8t5ul/t6LL2uITv0UmRDtXRalCIU4WNFGdULXYG+BjWbMjHexyK30Qy9s4VGX+KALh C96ziga6Ri68w== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id 37676F40068; Thu, 22 Jan 2026 19:42:39 -0500 (EST) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Thu, 22 Jan 2026 19:42:39 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddugeejieefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedfvehhuhgt khcunfgvvhgvrhdfuceotggvlheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrh hnpefghfeguedtieeiveeugfevtdejfedukeevgfeggfeugfetgfeltdetueelleelteen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegthhhutg hklhgvvhgvrhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeifeegleel leehledqfedvleekgeegvdefqdgtvghlpeepkhgvrhhnvghlrdhorhhgsehfrghsthhmrg hilhdrtghomhdpnhgspghrtghpthhtohepfeefpdhmohguvgepshhmthhpohhuthdprhgt phhtthhopehsvghnohiihhgrthhskhihsegthhhrohhmihhumhdrohhrghdprhgtphhtth hopegrughilhhgvghrrdhkvghrnhgvlhesughilhhgvghrrdgtrgdprhgtphhtthhopehs lhgrvhgrseguuhgsvgihkhhordgtohhmpdhrtghpthhtoheprhhonhhnihgvshgrhhhlsg gvrhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghnnhgrsehkvghrnhgvlhdrohhr ghdprhgtphhtthhopegsrhgruhhnvghrsehkvghrnhgvlhdrohhrghdprhgtphhtthhope gtvghmsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegthhgroheskhgvrhhnvghlrdho rhhgpdhrtghpthhtohepughjfihonhhgsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id F0153780076; Thu, 22 Jan 2026 19:42:38 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A--SnukTeK5R Date: Thu, 22 Jan 2026 19:42:15 -0500 From: "Chuck Lever" To: "Darrick J. Wong" Cc: "Alexander Viro" , "Christian Brauner" , "Jan Kara" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, "OGAWA Hirofumi" , "Namjae Jeon" , "Sungjong Seo" , "Yuezhang Mo" , almaz.alexandrovich@paragon-software.com, "Viacheslav Dubeyko" , glaubitz@physik.fu-berlin.de, frank.li@vivo.com, "Theodore Tso" , adilger.kernel@dilger.ca, "Carlos Maiolino" , "Steve French" , "Paulo Alcantara" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Trond Myklebust" , "Anna Schumaker" , "Jaegeuk Kim" , "Chao Yu" , "Hans de Goede" , senozhatsky@chromium.org, "Chuck Lever" Message-Id: In-Reply-To: <20260123002646.GL5945@frogsfrogsfrogs> References: <20260122160311.1117669-1-cel@kernel.org> <20260122160311.1117669-2-cel@kernel.org> <20260123002646.GL5945@frogsfrogsfrogs> Subject: Re: [PATCH v7 01/16] fs: Add case sensitivity flags to file_kattr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jan 22, 2026, at 7:26 PM, Darrick J. Wong wrote: > On Thu, Jan 22, 2026 at 11:02:56AM -0500, Chuck Lever wrote: >> From: Chuck Lever >>=20 >> Enable upper layers such as NFSD to retrieve case sensitivity >> information from file systems by adding FS_XFLAG_CASEFOLD and >> FS_XFLAG_CASENONPRESERVING flags. >>=20 >> Filesystems report case-insensitive or case-nonpreserving behavior >> by setting these flags directly in fa->fsx_xflags. The default >> (flags unset) indicates POSIX semantics: case-sensitive and >> case-preserving. These flags are read-only; userspace cannot set >> them via ioctl. >>=20 >> Remove struct file_kattr initialization from fileattr_fill_xflags() >> and fileattr_fill_flags(). Callers at ioctl/syscall entry points >> zero-initialize the struct themselves, which allows them to pass >> hints (flags_valid, fsx_valid) to the filesystem's ->fileattr_get() >> callback via the fa argument. Filesystem handlers that invoke these >> fill functions can now set flags directly in fa->fsx_xflags before >> calling them, without the fill functions zeroing those values. > > In hindsight I regret not asking for the file_kattr initialization > change to be in a separate patch. If I=E2=80=99m asked to post another revision of this series, I=E2=80=99= ll look at splitting 1/16 into two patches. >> Case sensitivity information is exported to userspace via the >> fa_xflags field in the FS_IOC_FSGETXATTR ioctl and file_getattr() >> system call. >>=20 >> Signed-off-by: Chuck Lever > > The UAPI changes still look ok to me. AFAICT the file_kattr > initialization now seem like they don't zap fields to confuse > vfs_fileattr_get. > > Reviewed-by: "Darrick J. Wong" --=20 Chuck Lever