From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 960F93FE44; Mon, 22 Jan 2024 20:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705953935; cv=none; b=TQQQbhSnlzC8Qxu4Ho6OUOFHAoiT5/o2QXm3lblXh5iPTccIb0FaHGAikNAK3RadzQ6TZnSE0Y3x+OOOadKQ6UUridiPPj3hTLZZXigYfYn3aVKjunCdbtvQvnItxBOSQsESm57M8IoyWwx5BQhDIejUOfAwaeHnIOFqmxK+/qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705953935; c=relaxed/simple; bh=KMfU13pO7wk9k2zkFFATZWe6HE92w9S7kkDhkNwNj54=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cjqzztfcUawwzpMGcWTeqaQWOZ9kaJ8J9eNjNJ9jyrFYAbBaFTitg2YN+aKjkJq+yLympfVi9Iw/bbj2IrqNVwdcQmtqUPuoV9L+KY69ZgUfhpTB700SEMYkE70qvT7cljd+tL4ATKr8tejCg6DDtEmOzjGA/sNm2vv4eji1ilI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6dc1f02090fso289505b3a.0; Mon, 22 Jan 2024 12:05:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705953934; x=1706558734; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Cr8LQYTS4LuxX0VHDB0eUkP92CbPkoPBe/FNUquwuo=; b=FHW3Gwo0meqGrS6U/25lKmmhufVoZkSMDNLO8d5PebK2K6aOjDFF49+ECvhfX7iJ1v t2719Owc+nc8owFNiENSiTbo0Hz4z91v4mfKyh5a+wbZrq6xiVJRGVwjs1IGWQnj1bgN rNBQlKK+YhVgJh0JRLPvdtrFQgJ3GkbLoSaRfeoX6ajPdNPJ/xqugFYl4Tv8SdzYbsy1 GuOpXr8hF3J5ADmZEqccBreuwOMX6REg3MTXWhZivp6XxQUQj3R6zU5+Cnd5Jps4JH+r xZP6jis1GOHViV8JF+qLrPReO2dYdqOqYlzMclmgzOviedf0wc4ztiB/QRVs2KYb1HHN 8amw== X-Gm-Message-State: AOJu0YyBDySozoDFCP13vlJZUOB1D788QagKTNIEJ0f+WxDrecwgJWWC Jri4330ydef3mT4cW3yQ+KfnHBlncvQmpN5SVXsl65/LPkWTEYoa X-Google-Smtp-Source: AGHT+IHRZRBlwmWgNMZkoqfrroa/veYvawWaRVXjvClre7ZjcoKSdytGOqY+fiSJXTyRqSGOKx/X8w== X-Received: by 2002:a05:6a20:d90f:b0:19a:6d4c:a71c with SMTP id jd15-20020a056a20d90f00b0019a6d4ca71cmr5574107pzb.37.1705953933652; Mon, 22 Jan 2024 12:05:33 -0800 (PST) Received: from [192.168.51.14] (c-73-231-117-72.hsd1.ca.comcast.net. [73.231.117.72]) by smtp.gmail.com with ESMTPSA id k4-20020aa78204000000b006d0a29ad0aasm9987906pfi.5.2024.01.22.12.05.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 12:05:32 -0800 (PST) Message-ID: Date: Mon, 22 Jan 2024 12:05:30 -0800 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 05/19] block, fs: Restore the per-bio/request data lifetime fields Content-Language: en-US To: Kanchan Joshi , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , Daejun Park , Alexander Viro , Christian Brauner References: <20231219000815.2739120-1-bvanassche@acm.org> <20231219000815.2739120-6-bvanassche@acm.org> <23354a9b-dd1e-5eed-f537-6a2de9185d7a@samsung.com> From: Bart Van Assche In-Reply-To: <23354a9b-dd1e-5eed-f537-6a2de9185d7a@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/22/24 01:23, Kanchan Joshi wrote: > On 12/19/2023 5:37 AM, Bart Van Assche wrote: > >> diff --git a/block/fops.c b/block/fops.c >> index 0abaac705daf..787ce52bc2c6 100644 >> --- a/block/fops.c >> +++ b/block/fops.c >> @@ -73,6 +73,7 @@ static ssize_t __blkdev_direct_IO_simple(struct kiocb *iocb, >> bio_init(&bio, bdev, vecs, nr_pages, dio_bio_write_op(iocb)); >> } >> bio.bi_iter.bi_sector = pos >> SECTOR_SHIFT; >> + bio.bi_write_hint = file_inode(iocb->ki_filp)->i_write_hint; >> bio.bi_ioprio = iocb->ki_ioprio; >> >> ret = bio_iov_iter_get_pages(&bio, iter); >> @@ -203,6 +204,7 @@ static ssize_t __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter, >> >> for (;;) { >> bio->bi_iter.bi_sector = pos >> SECTOR_SHIFT; >> + bio->bi_write_hint = file_inode(iocb->ki_filp)->i_write_hint; >> bio->bi_private = dio; >> bio->bi_end_io = blkdev_bio_end_io; >> bio->bi_ioprio = iocb->ki_ioprio; >> @@ -321,6 +323,7 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb, >> dio->flags = 0; >> dio->iocb = iocb; >> bio->bi_iter.bi_sector = pos >> SECTOR_SHIFT; >> + bio->bi_write_hint = file_inode(iocb->ki_filp)->i_write_hint; > > This (and two more places above) should rather be changed to: > > bio.bi_write_hint = bdev_file_inode(iocb->ki_filp)->i_write_hint; > > Note that at other places too (e.g., blkdev_fallocate, blkdev_mmap, > blkdev_lseek) bdev inode is used and not file inode. Why should this code be changed? The above code has been tested and works fine. Thanks, Bart.