From: John Garry <john.g.garry@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: axboe@kernel.dk, brauner@kernel.org, viro@zeniv.linux.org.uk,
jack@suse.cz, dchinner@redhat.com, hch@lst.de, cem@kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hare@suse.de, martin.petersen@oracle.com,
catherine.hoang@oracle.com, mcgrof@kernel.org,
ritesh.list@gmail.com, ojaswin@linux.ibm.com
Subject: Re: [PATCH v9 5/8] fs: iomap: Atomic write support
Date: Thu, 17 Oct 2024 08:57:26 +0100 [thread overview]
Message-ID: <be4d6b51-30b2-4669-aca8-29263d7eef97@oracle.com> (raw)
In-Reply-To: <20241016200347.GP21853@frogsfrogsfrogs>
On 16/10/2024 21:03, Darrick J. Wong wrote:
>> diff --git a/Documentation/filesystems/iomap/operations.rst b/Documentation/filesystems/iomap/operations.rst
>> index b93115ab8748..5f382076db67 100644
>> --- a/Documentation/filesystems/iomap/operations.rst
>> +++ b/Documentation/filesystems/iomap/operations.rst
>> @@ -513,6 +513,17 @@ IOMAP_WRITE`` with any combination of the following enhancements:
>> if the mapping is unwritten and the filesystem cannot handle zeroing
>> the unaligned regions without exposing stale contents.
>>
>> + * ``IOMAP_ATOMIC``: This write is being issued with torn-write
>> + protection. Only a single bio can be created for the write, and the
> Dumb nit: ^^ start new sentences on a new line like the rest of
> the file, please.
>
ok, np
> With that fixed,
> Reviewed-by: Darrick J. Wong<djwong@kernel.org>
cheers
next prev parent reply other threads:[~2024-10-17 7:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:03 [PATCH v9 0/8] block atomic writes for xfs John Garry
2024-10-16 10:03 ` [PATCH v9 1/8] block/fs: Pass an iocb to generic_atomic_write_valid() John Garry
2024-10-16 10:03 ` [PATCH v9 2/8] fs/block: Check for IOCB_DIRECT in generic_atomic_write_valid() John Garry
2024-10-16 19:57 ` Darrick J. Wong
2024-10-16 10:03 ` [PATCH v9 3/8] block: Add bdev atomic write limits helpers John Garry
2024-10-16 12:29 ` Christoph Hellwig
2024-10-16 12:36 ` John Garry
2024-10-16 12:39 ` Christoph Hellwig
2024-10-16 19:58 ` Darrick J. Wong
2024-10-16 10:03 ` [PATCH v9 4/8] fs: Export generic_atomic_write_valid() John Garry
2024-10-16 10:03 ` [PATCH v9 5/8] fs: iomap: Atomic write support John Garry
2024-10-16 20:03 ` Darrick J. Wong
2024-10-17 7:57 ` John Garry [this message]
2024-10-16 10:03 ` [PATCH v9 6/8] xfs: Support atomic write for statx John Garry
2024-10-16 10:03 ` [PATCH v9 7/8] xfs: Validate atomic writes John Garry
2024-10-16 12:29 ` Christoph Hellwig
2024-10-16 20:13 ` Darrick J. Wong
2024-10-16 10:03 ` [PATCH v9 8/8] xfs: Support setting FMODE_CAN_ATOMIC_WRITE John Garry
2024-10-16 20:13 ` Darrick J. Wong
2024-10-18 9:29 ` [PATCH v9 0/8] block atomic writes for xfs John Garry
2024-10-18 13:41 ` Jens Axboe
2024-10-18 17:43 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4d6b51-30b2-4669-aca8-29263d7eef97@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).