From: Jane Chu <jane.chu@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com,
viro@zeniv.linux.org.uk, brauner@kernel.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] dax: enable dax fault handler to report VM_FAULT_HWPOISON
Date: Thu, 6 Apr 2023 13:38:30 -0700 [thread overview]
Message-ID: <bfca2ab7-fbd3-1e7c-3128-c892c519697e@oracle.com> (raw)
In-Reply-To: <ZC8eVmF7YdBsDmc4@casper.infradead.org>
On 4/6/2023 12:32 PM, Matthew Wilcox wrote:
> On Thu, Apr 06, 2023 at 11:55:56AM -0600, Jane Chu wrote:
>> static vm_fault_t dax_fault_return(int error)
>> {
>> if (error == 0)
>> return VM_FAULT_NOPAGE;
>> - return vmf_error(error);
>> + else if (error == -ENOMEM)
>> + return VM_FAULT_OOM;
>> + else if (error == -EHWPOISON)
>> + return VM_FAULT_HWPOISON;
>> + return VM_FAULT_SIGBUS;
>> }
>
> Why would we want to handle it here instead of changing vmf_error()?
I think it's related to the comment about the the corrupted range of
a hwpoison caused fault - something no need to worry about now.
I will move the change to vmf_error() in a respin.
Thanks!
-jane
prev parent reply other threads:[~2023-04-06 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 17:55 [PATCH] dax: enable dax fault handler to report VM_FAULT_HWPOISON Jane Chu
2023-04-06 19:32 ` Matthew Wilcox
2023-04-06 20:38 ` Jane Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfca2ab7-fbd3-1e7c-3128-c892c519697e@oracle.com \
--to=jane.chu@oracle.com \
--cc=brauner@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).