Re: [PATCH 3/5] affs: rename affs_notify_change to affs_setattr

[Jan Kara <jack@suse.cz>]

On Wed 25-03-26 07:36:50, Christoph Hellwig wrote:
> Make the function name match the method that it implements.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/affs/affs.h    | 2 +-
>  fs/affs/dir.c     | 2 +-
>  fs/affs/file.c    | 2 +-
>  fs/affs/inode.c   | 5 ++---
>  fs/affs/symlink.c | 2 +-
>  5 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/affs/affs.h b/fs/affs/affs.h
> index ac4e9a02910b..43e20b02b449 100644
> --- a/fs/affs/affs.h
> +++ b/fs/affs/affs.h
> @@ -184,7 +184,7 @@ extern int	affs_rename2(struct mnt_idmap *idmap,
>  /* inode.c */
>  
>  extern struct inode		*affs_new_inode(struct inode *dir);
> -extern int			 affs_notify_change(struct mnt_idmap *idmap,
> +extern int			 affs_setattr(struct mnt_idmap *idmap,
>  					struct dentry *dentry, struct iattr *attr);
>  extern void			 affs_evict_inode(struct inode *inode);
>  extern struct inode		*affs_iget(struct super_block *sb,
> diff --git a/fs/affs/dir.c b/fs/affs/dir.c
> index 5c8d83387a39..c53b98f7c687 100644
> --- a/fs/affs/dir.c
> +++ b/fs/affs/dir.c
> @@ -71,7 +71,7 @@ const struct inode_operations affs_dir_inode_operations = {
>  	.mkdir		= affs_mkdir,
>  	.rmdir		= affs_rmdir,
>  	.rename		= affs_rename2,
> -	.setattr	= affs_notify_change,
> +	.setattr	= affs_setattr,
>  };
>  
>  static int
> diff --git a/fs/affs/file.c b/fs/affs/file.c
> index 6c9258359ddb..cede4bb1134e 100644
> --- a/fs/affs/file.c
> +++ b/fs/affs/file.c
> @@ -1013,5 +1013,5 @@ const struct file_operations affs_file_operations = {
>  };
>  
>  const struct inode_operations affs_file_inode_operations = {
> -	.setattr	= affs_notify_change,
> +	.setattr	= affs_setattr,
>  };
> diff --git a/fs/affs/inode.c b/fs/affs/inode.c
> index 0bfc7d151dcd..f660e76584b3 100644
> --- a/fs/affs/inode.c
> +++ b/fs/affs/inode.c
> @@ -213,13 +213,12 @@ affs_write_inode(struct inode *inode, struct writeback_control *wbc)
>  }
>  
>  int
> -affs_notify_change(struct mnt_idmap *idmap, struct dentry *dentry,
> -		   struct iattr *attr)
> +affs_setattr(struct mnt_idmap *idmap, struct dentry *dentry, struct iattr *attr)
>  {
>  	struct inode *inode = d_inode(dentry);
>  	int error;
>  
> -	pr_debug("notify_change(%lu,0x%x)\n", inode->i_ino, attr->ia_valid);
> +	pr_debug("setattr(%lu,0x%x)\n", inode->i_ino, attr->ia_valid);
>  
>  	error = setattr_prepare(&nop_mnt_idmap, dentry, attr);
>  	if (error)
> diff --git a/fs/affs/symlink.c b/fs/affs/symlink.c
> index 094aec8d17b8..af6147e1d975 100644
> --- a/fs/affs/symlink.c
> +++ b/fs/affs/symlink.c
> @@ -71,5 +71,5 @@ const struct address_space_operations affs_symlink_aops = {
>  
>  const struct inode_operations affs_symlink_inode_operations = {
>  	.get_link	= page_get_link,
> -	.setattr	= affs_notify_change,
> +	.setattr	= affs_setattr,
>  };
> -- 
> 2.47.3
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR