From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D098DC43381 for ; Tue, 26 Feb 2019 03:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D47B206B8 for ; Tue, 26 Feb 2019 03:40:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=synology.com header.i=@synology.com header.b="eMk7et6U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbfBZDkT (ORCPT ); Mon, 25 Feb 2019 22:40:19 -0500 Received: from mail.synology.com ([211.23.38.101]:52694 "EHLO synology.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726116AbfBZDkT (ORCPT ); Mon, 25 Feb 2019 22:40:19 -0500 X-Greylist: delayed 485 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Feb 2019 22:40:18 EST Received: from _ (localhost [127.0.0.1]) by synology.com (Postfix) with ESMTPA id BB41616FE302B; Tue, 26 Feb 2019 11:32:11 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synology.com; s=123; t=1551151931; bh=ialDz8v0ZUQhFp3huECfUJv27Hu5oHqh2LRVYqq8BFs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=eMk7et6UVnY22qd/baXFLVNgrBBa/DrUIB3ktpDGbpfQGLxFGW4mjz7OhEfKFOCfQ VhUy7sLXJysX9zNKVzaIGN+kv89EJJ+tjHHRj7P63UrRc4M2PewOxr8dz2CfApZoJN 87EaDMNFMT3UURahe9+jjfGdI6nNKRArKswYuXek= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 26 Feb 2019 11:32:11 +0800 From: tchou To: =?UTF-8?Q?Ernesto_A=2E_Fern=C3=A1ndez?= Cc: linux-fsdevel@vger.kernel.org, linux-fsdevel-owner@vger.kernel.org Subject: Re: The question about hfs+ patch (hfsplus: fix BUG on bnode parent update) In-Reply-To: <20190224004441.hhuakey36t2vvvag@eaf> References: <73216487-9ed5-4492-b7c6-b757fdb3b566@Mail> <20190224004441.hhuakey36t2vvvag@eaf> Message-ID: X-Sender: tchou@synology.com User-Agent: Roundcube Webmail/1.1.2 X-Synology-MCP-Status: no X-Synology-Spam-Flag: no X-Synology-Spam-Status: score=-0.101, required 6, __NOT_SPOOFED 0, TAGGED_RCPT 0, MID_RHS_MATCH_FROM 0, __KHOP_NO_FULL_NAME 0, TO_DN_SOME 0, FREEMAIL_TO 0, RCPT_COUNT_THREE 0, FROM_EQ_ENVFROM 0, FREEMAIL_ENVRCPT 0, MIME_GOOD -0.1, __THREADED 0, FROM_HAS_DN 0, RCVD_TLS_ALL 0, RCVD_COUNT_ZERO 0, NO_RECEIVED -0.001, TO_MATCH_ENVRCPT_ALL 0 X-Synology-Virus-Status: no Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Ernesto A. Fernández 於 2019-02-24 08:44 寫到: > Hi, > > On Sat, Feb 23, 2019 at 04:19:23PM +0800, tchou wrote: >> Hi Ernesto, >> >> Sorry to disturb. > > No problem. > >> I'm investigating an HFS+ BUG. >> The call trace is attached[1]. >> >> As you can see, the bnode is been free twice, >> I suspect that the bug is ralative to this patch >> 19a9d0f1acf75e8be8cfba19c1a34e941846fa2b >> (hfsplus: fix BUG on bnode parent update). > > Those messages you get are reporting an attempt to free on-disk bnodes > that > were already free. My patch was about bnode structures in memory, so > it's > not likely to be related. > >> >> There are three questions: >> 1. The commit message says "Creating, renaming or deleting a file may >> hit BUG_ON()". >> Where is the BUG_ON() been triggered? Is that the same BUG_ON() in my >> call trace? > > The BUG_ON() from my patch was in hfs_bnode_put(). I don't think there > is any > BUG_ON() in your case, you are getting a general protection fault. > >> >> 2. I run the script in your commit message, but I can not reproduce >> it. >> Could you please tell me how many times in average it need to execute >> to trigger the bug? >> I'm wondering if I took some mistake. > > The bug should be triggered after a single run. Did you revert the > patch > before? > >> >> >> 3. If my guess is wrong, this bug is unrelative to this patch, >> do you have any idea on it? Or do you have faced the same bug of mine? > > This seems to be related to the xattr implementation, which is a mess. > I think > it would be best to rewrite it or get rid of it entirely... Thanks for your reply! I will try to trace the code of xattr. > > Ernesto > >> Thanks for your help! >> >> [1] >> ================================================================================================== >> >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.504049] hfsplus: >> trying to free free bnode 294912(2) >> >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.510017] hfsplus: >> trying to free free bnode 294912(2) >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.515983] hfsplus: >> trying to free free bnode 294912(2) >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.521949] general >> protection fault: 0000 [#1] SMP >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.621069] CPU: 1 PID: >> 18715 Comm: SYNO.FileStatio Tainted: P C O 3.10.102 #15152 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.630308] Hardware name: >> Synology Inc. DS1517+/Type2 - Board Product Name1, BIOS M.405 >> 2017/05/09 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.640423] task: >> ffff8802753fa040 ti: ffff880270880000 task.ti: ffff880270880000 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.648779] RIP: >> 0010:[] [] >> hfsplus_bnode_write+0x9e/0x1e0 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.659489] RSP: >> 0018:ffff880270883c18 EFLAGS: 00010202 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.665415] RAX: >> 0000000000000000 RBX: 0000000000000002 RCX: 000000000000aeff >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.673391] RDX: >> 0000000000000000 RSI: ffff880270883c56 RDI: db73880000000000 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.681366] RBP: >> ffff88005f7b1920 R08: 0000000000000002 R09: 0000000000000002 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.689343] R10: >> ffff88005f7b18d0 R11: 0000000000000002 R12: 0000000000001ffc >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.697310] R13: >> ffff880270883c56 R14: 0000000000000002 R15: 0000000000000002 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.705286] FS: >> 00007f4fee0607c0(0000) GS:ffff88027fc40000(0000) >> knlGS:0000000000000000 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.714322] CS: 0010 DS: >> 0000 ES: 0000 CR0: 000000008005003b >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.720744] CR2: >> 00007f4fee05d000 CR3: 0000000247210000 CR4: 00000000001007e0 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.728711] DR0: >> 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.736687] DR3: >> 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.744654] Stack: >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.746896] >> ffff88005f7b18c0 ffff880270883cd0 0000000000001ffc 0000000000001f9c >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.755181] >> 0000000000000060 000000000000000e ffffffffa05146ff aeff000000000031 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.763468] >> ffffffffa0516bf9 000000606228c340 ffff880270883cd0 00000000fffffffe >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.771763] Call Trace: >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.774497] >> [] ? hfsplus_bnode_write_u16+0x1f/0x30 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.782671] >> [] ? hfsplus_brec_remove+0x129/0x190 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.790650] >> [] ? __hfsplus_delete_attr+0x90/0xf0 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.798629] >> [] ? hfsplus_delete_all_attrs+0x49/0xb0 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.806900] >> [] ? hfsplus_delete_cat+0x1c2/0x2b0 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.814782] >> [] ? hfsplus_unlink+0x1d0/0x1e0 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.822277] >> [] ? __inode_permission+0x1d/0xb0 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.828992] >> [] ? vfs_unlink+0x8a/0x100 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.835025] >> [] ? do_unlinkat+0x223/0x230 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.841255] >> [] ? mntput_no_expire+0x13/0x130 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.847873] >> [] ? task_work_run+0x9c/0xe0 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.854102] >> [] ? do_notify_resume+0x61/0x90 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.860624] >> [] ? fput+0x57/0xb0 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.865978] >> [] ? system_call_fastpath+0x16/0x1b >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.872884] Code: 48 63 ca >> 48 01 cf 48 83 fb 08 0f 83 fd 00 00 00 31 c0 41 f6 c3 04 74 09 8b 06 >> 89 07 b8 04 00 00 00 41 f6 c3 02 74 0c 0f b7 0c 06 <66> 89 0c 07 48 8d >> 40 02 41 83 e3 01 74 07 0f b6 0c 06 88 0c 07 >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.894293] RIP >> [] hfsplus_bnode_write+0x9e/0x1e0 [hfsplus] >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.902375] RSP >> >> >> 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.906350] ---[ end trace >> 0e65d1ee34a1e12e ]--- >> >> >> ================================================================================================== >> >> >> >> Best regards, >> Ting-Chang Hou #8487 >>