From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jeff Schroeder" Subject: Re: Btrfs v0.14 Released Date: Fri, 2 May 2008 11:14:56 -0700 Message-ID: References: <200804291601.32945.chris.mason@oracle.com> <200805020852.51125.chris.mason@oracle.com> <200805021034.08358.chris.mason@oracle.com> <481B3C0E.502@tpi.com> <481B409A.2070607@suse.com> <481B56FD.9020807@suse.com> Reply-To: jeffschroeder@computer.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Jan Engelhardt" , "Tim Gardner" , "Chris Mason" , "Tim Gardner" , linux-fsdevel@vger.kernel.org, kernel-team@lists.ubuntu.com, linux-btrfs@vger.kernel.org, "John Johansen" To: "Jeff Mahoney" Return-path: Received: from el-out-1112.google.com ([209.85.162.179]:62062 "EHLO el-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756211AbYEBSPF (ORCPT ); Fri, 2 May 2008 14:15:05 -0400 Received: by el-out-1112.google.com with SMTP id n30so625023elf.21 for ; Fri, 02 May 2008 11:15:04 -0700 (PDT) In-Reply-To: <481B56FD.9020807@suse.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 2, 2008 at 11:01 AM, Jeff Mahoney wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > > Jan Engelhardt wrote: > > On Friday 2008-05-02 18:26, Jeff Mahoney wrote: > >>> To the best of my knowledge, the AppArmor patches are arch and flavour > >>> independent. If CONFIG_SECURITY_APPARMOR exists, then the AA code is > >>> compiled. This is certainly the case for Hardy. Neither Kees or myself > >>> are aware of any reason why it won't also hold true for Intrepid. > >> Grumble. The issue isn't whether AA is enabled, it's whether it's > >> present in the source. Patching the source with AA modifies a bunch of > >> core VFS function prototypes. CONFIG_SECURITY_APPARMOR won't exist if AA > >> isn't enabled, but the prototypes will have changed anyway. > > > > So... add an invisible CONFIG_HAVE_APPARMOR, much like > > CONFIG_X86_HAVE_CMPXCHG (or whatever it's called), and test for that. > > As long as you are not in the mainline kernel, every hack is > > forgiven. > > That'll work moving forward, but btrfs also supports older releases. > > > - -Jeff So how about this for older releases? It should work on Ubuntu 7.10 or 8.10 installs with apparmor enabled by default: #if defined(CONFIG_VERSION_SIGNATURE) # if (LINUX_VERSION_CODE = KERNEL_VERSION(2,6,24)) || (LINUX_VERSION_CODE = KERNEL_VERSION(2,6,20)) # define REMOVE_SUID_PATH 1 # endif #endif Maybe add a blurb in the install doc about this for users trying to build ubuntu kernels with no apparmor (probably a rarity). CONFIG_VERSION_SIGNATURE can be likened to CONFIG_SUSE -- Jeff Schroeder Don't drink and derive, alcohol and analysis don't mix. http://www.digitalprognosis.com