From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Suren Baghdasaryan <surenb@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Gao Xiang <xiang@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-mm@kvack.org
Subject: Re: improve pagecache PSI annotations
Date: Sat, 10 Sep 2022 05:32:25 -0600 [thread overview]
Message-ID: <c76b45ad-c4ef-5166-fec3-a05e2febcce3@kernel.dk> (raw)
In-Reply-To: <20220910065058.3303831-1-hch@lst.de>
On 9/10/22 12:50 AM, Christoph Hellwig wrote:
> Hi all,
>
> currently the VM tries to abuse the block layer submission path for
> the page cache PSI annotations. This series instead annotates the
> ->read_folio and ->readahead calls in the core VM code, and then
> only deals with the odd direct add_to_page_cache_lru calls manually.
>
> Diffstat:
> block/bio.c | 8 --------
> block/blk-core.c | 17 -----------------
> fs/btrfs/compression.c | 14 ++++++++++++--
> fs/direct-io.c | 2 --
> fs/erofs/zdata.c | 13 ++++++++++++-
> include/linux/blk_types.h | 1 -
> include/linux/pagemap.h | 2 ++
> kernel/sched/psi.c | 2 ++
> mm/filemap.c | 7 +++++++
> mm/readahead.c | 22 ++++++++++++++++++----
> 10 files changed, 53 insertions(+), 35 deletions(-)
Nice! It's always bothered me that we have this weird layering
here.
--
Jens Axboe
prev parent reply other threads:[~2022-09-10 11:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 6:50 improve pagecache PSI annotations Christoph Hellwig
2022-09-10 6:50 ` [PATCH 1/5] mm: add PSI accounting around ->read_folio and ->readahead calls Christoph Hellwig
2022-09-10 11:34 ` Jens Axboe
2022-09-12 8:35 ` Christoph Hellwig
2022-09-10 18:26 ` Matthew Wilcox
2022-09-12 8:33 ` Christoph Hellwig
2022-09-14 11:41 ` Johannes Weiner
2022-09-10 6:50 ` [PATCH 2/5] sched/psi: export psi_memstall_{enter,leave} Christoph Hellwig
2022-09-14 11:42 ` Johannes Weiner
2022-09-10 6:50 ` [PATCH 3/5] btrfs: add manual PSI accounting for compressed reads Christoph Hellwig
2022-09-12 15:28 ` David Sterba
2022-09-14 11:46 ` Johannes Weiner
2022-09-10 6:50 ` [PATCH 4/5] erofs: add manual PSI accounting for the compressed address space Christoph Hellwig
2022-09-14 11:47 ` Johannes Weiner
2022-09-14 12:47 ` Gao Xiang
2022-09-10 6:50 ` [PATCH 5/5] block: remove PSI accounting from the bio layer Christoph Hellwig
2022-09-14 11:48 ` Johannes Weiner
2022-09-10 11:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c76b45ad-c4ef-5166-fec3-a05e2febcce3@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).