From: Dan Carpenter <dan.carpenter@linaro.org>
To: Baoquan He <bhe@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Vivek Goyal <vgoyal@redhat.com>,
akpm@linux-foundation.org, Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] proc/vmcore: fix signedness bug in read_from_oldmem()
Date: Wed, 26 Jul 2023 09:03:05 +0300 [thread overview]
Message-ID: <c770613e-1f11-4bff-bc5f-9bc6f07a4da5@kadam.mountain> (raw)
In-Reply-To: <ZMC1jU7ywPGt1QmO@MiWiFi-R3L-srv>
On Wed, Jul 26, 2023 at 01:56:29PM +0800, Baoquan He wrote:
>
> Thanks for this fix. Just curious, this is found out by code exploring,
> or any breaking?
It's from static analysis, looking at when error codes are type promoted
to unsigned. I pushed the Smatch check for this yesterday.
https://github.com/error27/smatch/commit/a2e6ca07e2ef83a72c9ffa3508af1398a6ecc7ed
regards,
dan carpenter
next prev parent reply other threads:[~2023-07-26 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 17:03 [PATCH] proc/vmcore: fix signedness bug in read_from_oldmem() Dan Carpenter
2023-07-26 4:10 ` Matthew Wilcox
2023-07-26 5:56 ` Baoquan He
2023-07-26 6:03 ` Dan Carpenter [this message]
2023-07-26 8:41 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c770613e-1f11-4bff-bc5f-9bc6f07a4da5@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).