From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16647C77B61 for ; Fri, 28 Apr 2023 08:57:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345808AbjD1I5b (ORCPT ); Fri, 28 Apr 2023 04:57:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345790AbjD1I5O (ORCPT ); Fri, 28 Apr 2023 04:57:14 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBC32D65; Fri, 28 Apr 2023 01:56:53 -0700 (PDT) Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Q75zn3Zk8z8wyT; Fri, 28 Apr 2023 16:55:49 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 28 Apr 2023 16:56:49 +0800 Message-ID: Date: Fri, 28 Apr 2023 16:56:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2] mm: hwpoison: coredump: support recovery from dump_user_range() Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: "Luck, Tony" , "chu, jane" , Thomas Gleixner , Alexander Viro , Christian Brauner , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Miaohe Lin , "linux-kernel@vger.kernel.org" , Tong Tiangen , Jens Axboe References: <9a9876a2-a2fd-40d9-b215-3e6c8207e711@huawei.com> <20230421031356.GA3048466@hori.linux.bs1.fc.nec.co.jp> <1bd6a635-5a3d-c294-38ce-5c6fcff6494f@huawei.com> <20230424064427.GA3267052@hori.linux.bs1.fc.nec.co.jp> <316b5a9e-5d5f-3bcf-57c1-86fafe6681c3@huawei.com> <6b350187-a9a5-fb37-79b1-bf69068f0182@huawei.com> <20230427023045.GA3499768@hori.linux.bs1.fc.nec.co.jp> From: Kefeng Wang In-Reply-To: <20230427023045.GA3499768@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2023/4/27 10:31, HORIGUCHI NAOYA(堀口 直也) wrote: > On Thu, Apr 27, 2023 at 09:06:46AM +0800, Kefeng Wang wrote: >> >> ... >> For coredump，the task work will be called too, see following code, >> >> get_signal >> sig_kernel_coredump >> elf_core_dump >> dump_user_range >> _copy_from_iter // with MC-safe copy, return without panic >> do_group_exit(ksig->info.si_signo); >> do_exit >> exit_task_work >> task_work_run >> kill_me_never >> memory_failure >> >> I also add debug print to check the memory_failure() processing after >> add MCE_IN_KERNEL_COPYIN to MCE_SAFE exception type, also tested CoW of >> normal page and huge page, it works too. > > Sounds nice to me. > Maybe this information is worth documenting in the patch description. > Sure, will make a formal patch and send out, thanks. > Thanks, > Naoya Horiguchi