linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Pinto <danielpinto52@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] fs/ntfs3: fix hidedotfiles mount option by reversing, behaviour
Date: Fri, 7 Oct 2022 13:36:39 +0100	[thread overview]
Message-ID: <ca14dc16-a00e-bff3-500f-4c9227a30674@gmail.com> (raw)
In-Reply-To: <536f13a9-0890-7e69-65e9-5fe1a30e04ef@gmail.com>

Currently, the hidedotfiles mount option is behaving in the reverse
way of what would be expected: enabling it disables setting the
hidden attribute on files or directories with names starting with a
dot and disabling it enables the setting.

Reverse the behaviour of the hidedotfiles mount option so it matches
what is expected.

Signed-off-by: Daniel Pinto <danielpinto52@gmail.com>
---
 fs/ntfs3/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 1e2c04e48f98..c6fd2afde172 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -359,7 +359,7 @@ static int ntfs_fs_parse_param(struct fs_context *fc,
 		opts->nohidden = result.negated ? 1 : 0;
 		break;
 	case Opt_hide_dot_files:
-		opts->hide_dot_files = result.negated ? 1 : 0;
+		opts->hide_dot_files = result.negated ? 0 : 1;
 		break;
 	case Opt_acl:
 		if (!result.negated)

  reply	other threads:[~2022-10-07 12:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 12:32 [PATCH 0/4] fs/ntfs3: Fix and rename hidedotfiles mount option Daniel Pinto
2022-10-07 12:36 ` Daniel Pinto [this message]
2022-10-07 12:38 ` [PATCH 2/4] fs/ntfs3: make hidedotfiles mount option work when renaming files Daniel Pinto
2022-10-07 12:40 ` [PATCH 3/4] fs/ntfs3: add hidedotfiles to the list of enabled mount options Daniel Pinto
2022-10-07 12:43 ` [PATCH 4/4] fs/ntfs3: rename hidedotfiles mount option to hide_dot_files Daniel Pinto
     [not found] ` <CAKBF=ps4CUA3crkzUUn8J-0WC-6bGb3Z9PPugzebTajGJ+=rSA@mail.gmail.com>
2022-10-10 11:50   ` [PATCH 0/4] fs/ntfs3: Fix and rename hidedotfiles mount option Daniel Pinto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca14dc16-a00e-bff3-500f-4c9227a30674@gmail.com \
    --to=danielpinto52@gmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).