From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9330C05051 for ; Wed, 9 Aug 2023 19:05:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbjHITFd (ORCPT ); Wed, 9 Aug 2023 15:05:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjHITFb (ORCPT ); Wed, 9 Aug 2023 15:05:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5DE7E71; Wed, 9 Aug 2023 12:05:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B6A964095; Wed, 9 Aug 2023 19:05:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5CFC433C8; Wed, 9 Aug 2023 19:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691607929; bh=4GKDaia1VeW/OijfJXE9UHIufNesebWNQDy9LU2whYI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=gEyeaJZ4RUWChIryvRrKWbHk6CbM8eHu0rqtHvzvba6SSDpBpPtag+D6BMw4GFw2n hFXK4OEbm0L9R1B4K8eNiaiBDtquinDOVTFyiDIMSP6pKYqwvVgkMBHyc14BMMGMP8 zAV3KdTeX3lKcSKjE5oKnAjO29eKsnCAgTvUvEsF/+3xUpWxGZvbyls48Ed9vXaSwV DcuV4QvGf703nsP6BpmM4kVysUgEr6LDinf8/zizcxdQ20sie+EHfzuPrXj/APOCtH 91Mo4Dg4M0l0SApVPB8n1GBtVl5sn3TKwCbUSa9ZQiDyJiArJw0iRB7MWozIYejid0 q+2d4Xd9I1nbw== Message-ID: Subject: Re: [PATCH v7 08/13] fs: drop the timespec64 argument from update_time From: Jeff Layton To: Mike Marshall , Christian Brauner Cc: Alexander Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Date: Wed, 09 Aug 2023 15:05:21 -0400 In-Reply-To: References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-8-d1dec143a704@kernel.org> <20230809-segeln-pflaumen-460b81bd2d3a@brauner> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Yes. It's in Christian's vfs.ctime branch: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=3Dvfs.ct= ime On Wed, 2023-08-09 at 14:38 -0400, Mike Marshall wrote: > I've been following this patch on fsdevel... is there a > remote I could fetch with a branch that has this in it? >=20 > -Mike >=20 > On Wed, Aug 9, 2023 at 8:32=E2=80=AFAM Christian Brauner wrote: > >=20 > > On Mon, Aug 07, 2023 at 03:38:39PM -0400, Jeff Layton wrote: > > > Now that all of the update_time operations are prepared for it, we ca= n > > > drop the timespec64 argument from the update_time operation. Do that = and > > > remove it from some associated functions like inode_update_time and > > > inode_needs_update_time. > > >=20 > > > Signed-off-by: Jeff Layton > > > --- > > > fs/bad_inode.c | 3 +-- > > > fs/btrfs/inode.c | 3 +-- > > > fs/btrfs/volumes.c | 4 +--- > > > fs/fat/fat.h | 3 +-- > > > fs/fat/misc.c | 2 +- > > > fs/gfs2/inode.c | 3 +-- > > > fs/inode.c | 30 +++++++++++++----------------- > > > fs/overlayfs/inode.c | 2 +- > > > fs/overlayfs/overlayfs.h | 2 +- > > > fs/ubifs/file.c | 3 +-- > > > fs/ubifs/ubifs.h | 2 +- > > > fs/xfs/xfs_iops.c | 1 - > > > include/linux/fs.h | 4 ++-- > >=20 > > This was missing the conversion of fs/orangefs orangefs_update_time() > > causing the build to fail. So at some point kbuild will yell here. > > Fwiw, I've fixed that up in-tree. Cheers, --=20 Jeff Layton