From: Miaohe Lin <linmiaohe@huawei.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: <djwong@kernel.org>, <dan.j.williams@intel.com>,
<david@fromorbit.com>, <hch@infradead.org>, <jane.chu@oracle.com>,
Christoph Hellwig <hch@lst.de>, <linux-kernel@vger.kernel.org>,
<linux-xfs@vger.kernel.org>, <nvdimm@lists.linux.dev>,
<linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v13 3/7] pagemap,pmem: Introduce ->memory_failure()
Date: Sun, 24 Apr 2022 10:00:23 +0800 [thread overview]
Message-ID: <cc219e5d-a400-776c-116b-21e5d1470045@huawei.com> (raw)
In-Reply-To: <4a808b12-9215-9421-d114-951e70764778@fujitsu.com>
On 2022/4/22 15:06, Shiyang Ruan wrote:
>
>
...
>>
>> Thanks for your patch. There are two questions:
>>
>> 1.Is dax_lock_page + dax_unlock_page pair needed here?
>
> They are moved into mf_generic_kill_procs() in Patch2. Callback will implement its own dax lock/unlock method. For example, for mf_dax_kill_procs() in Patch4, we implemented dax_lock_mapping_entry()/dax_unlock_mapping_entry() for it.
>
>> 2.hwpoison_filter and SetPageHWPoison will be handled by the callback or they're just ignored deliberately?
>
> SetPageHWPoison() will be handled by callback or by mf_generic_kill_procs().
>
> hwpoison_filter() is moved into mf_generic_kill_procs() too. The callback will make sure the page is correct, so it is ignored.
I see this when I read the other patches. Many thanks for clarifying!
>
>
> --
> Thanks,
> Ruan.
>
>>
>> Thanks!
>>
>>> rc = mf_generic_kill_procs(pfn, flags, pgmap);
>>> out:
>>> /* drop pgmap ref acquired in caller */
>>>
>>
>
>
> .
next prev parent reply other threads:[~2022-04-24 2:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 4:50 [PATCH v13 0/7] fsdax: introduce fs query to support reflink Shiyang Ruan
2022-04-19 4:50 ` [PATCH v13 1/7] dax: Introduce holder for dax_device Shiyang Ruan
2022-04-20 17:42 ` Darrick J. Wong
2022-04-19 4:50 ` [PATCH v13 2/7] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2022-04-21 6:13 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-21 8:10 ` Shiyang Ruan
2022-04-21 8:12 ` Miaohe Lin
2022-04-19 4:50 ` [PATCH v13 3/7] pagemap,pmem: Introduce ->memory_failure() Shiyang Ruan
2022-04-20 17:45 ` Darrick J. Wong
2022-04-21 6:54 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-21 8:24 ` Miaohe Lin
2022-04-22 7:06 ` Shiyang Ruan
2022-04-24 2:00 ` Miaohe Lin [this message]
2022-04-19 4:50 ` [PATCH v13 4/7] fsdax: Introduce dax_lock_mapping_entry() Shiyang Ruan
2022-04-20 17:53 ` Darrick J. Wong
2022-04-19 4:50 ` [PATCH v13 5/7] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2022-04-20 17:58 ` Darrick J. Wong
2022-04-21 8:47 ` Miaohe Lin
2022-04-21 12:50 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-19 4:50 ` [PATCH v13 6/7] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2022-04-19 15:38 ` Darrick J. Wong
2022-04-20 7:33 ` [PATCH v13.1 " Shiyang Ruan
2022-04-20 17:30 ` Darrick J. Wong
2022-04-19 4:50 ` [PATCH v13 7/7] fsdax: set a CoW flag when associate reflink mappings Shiyang Ruan
2022-04-19 7:27 ` Christoph Hellwig
2022-04-20 17:35 ` Darrick J. Wong
2022-04-21 1:20 ` [PATCH v13 0/7] fsdax: introduce fs query to support reflink Dave Chinner
2022-04-21 1:48 ` Shiyang Ruan
2022-04-21 2:20 ` Dan Williams
2022-04-21 4:35 ` Dave Chinner
2022-04-21 5:47 ` HORIGUCHI NAOYA(堀口 直也)
2022-04-21 5:54 ` Christoph Hellwig
2022-04-21 7:46 ` Dave Chinner
2022-04-22 21:27 ` Dan Williams
2022-04-23 0:01 ` Dave Chinner
2022-04-23 17:32 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc219e5d-a400-776c-116b-21e5d1470045@huawei.com \
--to=linmiaohe@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).