From: Jeff Layton <jlayton@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>,
viro@zeniv.linux.org.uk, bfields@fieldses.org
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs/locks: remove useless assignments
Date: Tue, 13 Apr 2021 07:28:41 -0400 [thread overview]
Message-ID: <cd9af9a5f8fd0f6ff088290695225ae385b1d15d.camel@kernel.org> (raw)
In-Reply-To: <1618279103-45362-1-git-send-email-tiantao6@hisilicon.com>
On Tue, 2021-04-13 at 09:58 +0800, Tian Tao wrote:
> Function parameter 'cmd' is rewritten with unused value at locks.c
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> fs/locks.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/locks.c b/fs/locks.c
> index 53cf033..5c42363 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -2369,7 +2369,6 @@ int fcntl_getlk(struct file *filp, unsigned int cmd, struct flock *flock)
> if (flock->l_pid != 0)
> goto out;
>
> - cmd = F_GETLK;
> fl->fl_flags |= FL_OFDLCK;
> fl->fl_owner = filp;
> }
Thanks, merged into the locks-next branch and should make v5.13.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2021-04-13 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 1:58 [PATCH] fs/locks: remove useless assignments Tian Tao
2021-04-13 11:28 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd9af9a5f8fd0f6ff088290695225ae385b1d15d.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).