Re: [PATCH 0/2] fsnotify hooks consolidation

[Jeff Layton <jlayton@kernel.org>]

On Mon, 2026-03-02 at 19:37 +0100, Amir Goldstein wrote:
> Jan,
> 
> I've found this opportunity to reduce the amount of sprinkled
> fsnotify hooks.
> 
> There are still a few fsnotify hooks sprinkled in some pseudo fs,
> but all those removed by this series are obvious boiler plate code
> and for most of these fs, this removes all of the custom hooks.
> 
> I could send a series to convert each fs with its own patch,
> but to me that seems a bit unnecessary.
> 
> WDYT?
> Amir.
> 
> Amir Goldstein (2):
>   fsnotify: make fsnotify_create() agnostic to file/dir
>   fs: use simple_end_creating helper to consolidate fsnotify hooks
> 
>  drivers/android/binder/rust_binderfs.c | 11 +++--------
>  drivers/android/binderfs.c             | 10 +++-------
>  fs/debugfs/inode.c                     |  5 +----
>  fs/libfs.c                             | 14 ++++++++++++++
>  fs/nfsd/nfsctl.c                       | 11 +++--------
>  fs/tracefs/event_inode.c               |  2 --
>  fs/tracefs/inode.c                     |  5 +----
>  include/linux/fs.h                     |  1 +
>  include/linux/fsnotify.h               |  8 +++++++-
>  net/sunrpc/rpc_pipe.c                  | 10 +++-------
>  10 files changed, 36 insertions(+), 41 deletions(-)

Conceptually, this all seems fine.

My only gripe is that there is nothing mnemonic about the names
simple_done_creating() and simple_end_creating(). Since the only
difference are the notification bits, maybe
simple_done_creating_notify() is a better name?

Reviewed-by: Jeff Layton <jlayton@kernel.org>