From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD85C433FE for ; Fri, 1 Apr 2022 15:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348771AbiDAP5T (ORCPT ); Fri, 1 Apr 2022 11:57:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241829AbiDAPRr (ORCPT ); Fri, 1 Apr 2022 11:17:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 69FC156C18 for ; Fri, 1 Apr 2022 08:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648825235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4C2FtsuZxf0/Q/b0iTYDkQBo4MdhWNl+MwxPx5dtPM=; b=VpAe2EIUSKbKVmhAHUO1Pk9jpYYqOBX6Gng1bdtta5u8CaZ5YqEKxst5J+FD7Xm4TKE4i/ 4UEEaUBqlOS64CunHafcQgd82wgvtsPdZqBmr+hbHmi7so1ulAOCmBIXkuhHU4loncxm72 BSm7tBnI+CMEV2wguY+Z3I0zKoOAlig= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-P1JVZu8CMc68bIXcRe2o1g-1; Fri, 01 Apr 2022 11:00:34 -0400 X-MC-Unique: P1JVZu8CMc68bIXcRe2o1g-1 Received: by mail-ed1-f72.google.com with SMTP id c31-20020a509fa2000000b004190d43d28fso1673710edf.9 for ; Fri, 01 Apr 2022 08:00:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=U4C2FtsuZxf0/Q/b0iTYDkQBo4MdhWNl+MwxPx5dtPM=; b=IqPitLw3nhWxckd8fr03G/qCHp1UUR6Du0aJb7mLl00Bw5UuhMV9or2871wLrHfvL4 4DMPJEtAQutnYlh2MsRUXakEWgN84/jLYasTV8f2y6dSBAUAcSOqCh0OypfVKXO+e+Me H7FF8DtlOUmyWp0nP2wkJNlWPTMfydyrhB/DXkOONYf/hhv2evq3TcsXVTG2VtbzPWIi 20qGGfKMOj//IFgRz+nPlpgPvNAOZW4Lr+RU275xByzwKLTGhEd7iXbuL3HHNnZumoag c5iwJRFNG2h5e+aJSOJ3bGD/dyLnoudss5WVwalAG3dOXstKXeWmyTckaFcrzgceaKO+ 92Uw== X-Gm-Message-State: AOAM531BInvsQP8qcqZI+gqNUD/LStH6KWY9tqo6LGnEuy3uD4Z3nl8t kDhh4wwOhlCcpsQqbuAM/ojE3DeUH6Lxm4DXyNI+rv2+cJvJ0iZkV2D9cwTsSC1V/+WBPzZcYiw Mlw0UzA9EHu1th3AUHTMqV4JMSg== X-Received: by 2002:a05:6402:27d2:b0:419:1a3d:442b with SMTP id c18-20020a05640227d200b004191a3d442bmr20841617ede.409.1648825232196; Fri, 01 Apr 2022 08:00:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVAReUv2SvSmu/TQtO7iDA9+C4zYyJ+bufOOhAWSyh+evkJ1N0aCK5WKLJdbVvtRrCxIoc7A== X-Received: by 2002:a05:6402:27d2:b0:419:1a3d:442b with SMTP id c18-20020a05640227d200b004191a3d442bmr20841583ede.409.1648825231922; Fri, 01 Apr 2022 08:00:31 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id gb29-20020a170907961d00b006e00c7b0f5asm1096476ejc.0.2022.04.01.08.00.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 08:00:31 -0700 (PDT) Message-ID: Date: Fri, 1 Apr 2022 17:00:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o) Content-Language: en-US To: "Limonciello, Mario" , Randy Dunlap , Andrew Morton , "broonie@kernel.org" , "mhocko@suse.cz" , "sfr@canb.auug.org.au" , "linux-next@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "mm-commits@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" References: <20220330200158.2F031C340EC@smtp.kernel.org> <5a0b94c3-406e-463e-d93e-d1dc2a260b47@infradead.org> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Mario, On 3/31/22 20:41, Limonciello, Mario wrote: > [AMD Official Use Only] > >> -----Original Message----- >> From: Randy Dunlap >> Sent: Thursday, March 31, 2022 10:51 >> To: Andrew Morton ; broonie@kernel.org; >> mhocko@suse.cz; sfr@canb.auug.org.au; linux-next@vger.kernel.org; linux- >> fsdevel@vger.kernel.org; linux-mm@kvack.org; linux- >> kernel@vger.kernel.org; mm-commits@vger.kernel.org; platform-driver- >> x86@vger.kernel.org; Limonciello, Mario >> Subject: Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd- >> pmc.o) >> >> >> >> On 3/30/22 13:01, Andrew Morton wrote: >>> The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to >>> >>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww >> w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo >> nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe >> 4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha >> WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb >> V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0 >>> >>> mmotm-readme.txt says >>> >>> README for mm-of-the-moment: >>> >>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww >> w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo >> nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe >> 4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha >> WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb >> V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0 >>> >>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>> more than once a week. >>> >>> You will need quilt to apply these patches to the latest Linus release (5.x >>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >>> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fozla >> bs.org%2F~akpm%2Fmmotm%2Fseries&data=04%7C01%7Cmario.limon >> ciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe4 >> 884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown >> %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha >> WwiLCJXVCI6Mn0%3D%7C3000&sdata=adnYHchdMvieQ0lCqQ1er1jhHA >> UMomgFpaWBo%2BMnINk%3D&reserved=0 >>> >> >> on x86_64: >> when CONFIG_SUSPEND is not set: >> >> drivers/platform/x86/amd-pmc.o: in function `amd_pmc_remove': >> amd-pmc.c:(.text+0x11d): undefined reference to >> `acpi_unregister_lps0_dev' >> ld: drivers/platform/x86/amd-pmc.o: in function `amd_pmc_probe': >> amd-pmc.c:(.text+0x20be): undefined reference to `acpi_register_lps0_dev' >> >> >> >> -- >> ~Randy > > AFAICT you're missing 20e1d6402a71dba7ad2b81f332a3c14c7d3b939b. That is unlikely since the whole series got merged through the pdx86/for-next branch, so either some other tree has the whole series or none of it. Also note that Randy wrote: "when CONFIG_SUSPEND is not set" The problem is that all of drivers/acpi/x86/s2idle.c is wrapped by #ifdef CONFIG_SUSPEND ... #endif Since AFAIK the whole amd-pmc driver's whole purpose is to allow s2idle to work properly. I think this can be fixed by simply doing: --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -198,7 +198,7 @@ config ACER_WMI config AMD_PMC tristate "AMD SoC PMC driver" - depends on ACPI && PCI && RTC_CLASS + depends on ACPI && SUSPEND && PCI && RTC_CLASS help The driver provides support for AMD Power Management Controller primarily responsible for S2Idle transactions that are driven from If you agree, please submit a patch with this change and I'll queue it up in my fixes branch. Regards, Hans