From: Paulo Alcantara <pc@manguebit.org>
To: David Howells <dhowells@redhat.com>, Steve French <sfrench@samba.org>
Cc: dhowells@redhat.com, Christian Brauner <brauner@kernel.org>,
linux-cifs@vger.kernel.org, netfs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix missing credit release on failure in cifs_issue_read()
Date: Thu, 02 Jul 2026 09:53:11 -0300 [thread overview]
Message-ID: <cfbb3e301d90d034922b945c522813df@manguebit.org> (raw)
In-Reply-To: <138902.1782980700@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> writes:
> Fix missing release of credits in the failure path in cifs_issue_read()
> lest retrying the subreq just overwrites the credits value.
>
> Fixes: 69c3c023af25 ("cifs: Implement netfslib hooks")
> Link: https://sashiko.dev/#/patchset/20260608145432.681865-1-dhowells%40redhat.com
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Steve French <sfrench@samba.org>
> cc: Paulo Alcantara <pc@manguebit.org>
> cc: linux-cifs@vger.kernel.org
> cc: netfs@lists.linux.dev
> cc: linux-fsdevel@vger.kernel.org
> ---
> fs/smb/client/file.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
next prev parent reply other threads:[~2026-07-02 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 8:25 [PATCH] cifs: Fix missing credit release on failure in cifs_issue_read() David Howells
2026-07-02 12:53 ` Paulo Alcantara [this message]
2026-07-02 14:22 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfbb3e301d90d034922b945c522813df@manguebit.org \
--to=pc@manguebit.org \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox