From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC9F5336B for ; Wed, 24 Jul 2024 07:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721806441; cv=none; b=tc/ZK5jFxc9OSw3F344DTl5r0H0FPG269qZ6dk+6xxvSl3VFsKABvfLunjZyG0KqTmy/98K9A5N8M6AdDzJjCzRLYD6D14SI87eaxOn6DmH7mgojwRIls3Jfl6rYPqi1Ms3cSynZ7x9rRGkhjAw/kiSIpXojIPzh7qLTnaL0NVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721806441; c=relaxed/simple; bh=i6qjkdUePQuOA+i1d6kmyuaPxep0vlMZsujaMzjzN+0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nxw/a41YkrwxagGQdTl/U3bSF8SOlYRVCxQvxS3KCheOWpLh25XIJJnBeiu4lDm+fqMVpZf+67OdbrQBSz4tpePZRAHqTY1DdIHFKRAk5Hr+CnsJwcjcoeSQVEYTgOiBTPcRK6Y7b1wI93nCD3CtmSo8/B6sI6gQCwxzwExSvUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=DceoZyTw; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DceoZyTw" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721806437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2MuHRu4ooOvmdV8vJNdd7cZLAuF4g4MEIkwqOWBKA=; b=DceoZyTw7tNaiJeOpXLh2xDm2mY6q8Uh0yzm7aYYpnK9UuCZzG5y4oMGyOZDSclMGzGyAz RzjBzrdKtzviNE0Yxfx5+l8lFLS5RJWpU9V1HJUGRXODN3A0duGcu4zngxPjfzHqPzVKc5 y1RWI6+H1QvpEFOnHinDw4v/OAEH9A4= Date: Wed, 24 Jul 2024 15:33:38 +0800 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include To: Alexander Viro , Christian Brauner Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Youling Tang , Jan Kara References: <20240603014834.45294-1-youling.tang@linux.dev> <20240603111844.l4g2yk5q6z23cz3n@quack3> Content-Language: en-US, en-AU X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Youling Tang In-Reply-To: <20240603111844.l4g2yk5q6z23cz3n@quack3> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi, On 03/06/2024 19:18, Jan Kara wrote: > On Mon 03-06-24 09:48:34, Youling Tang wrote: >> From: Youling Tang >> >> After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing >> in this file needs anything from `linux/prefetch.h`. >> >> Signed-off-by: Youling Tang Sorry to bother you, but do we still need this patch? Thanks, Youling. > Looks good. Feel free to add: > > Reviewed-by: Jan Kara > > Honza > >> --- >> fs/direct-io.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/fs/direct-io.c b/fs/direct-io.c >> index b0aafe640fa4..bbd05f1a2145 100644 >> --- a/fs/direct-io.c >> +++ b/fs/direct-io.c >> @@ -37,7 +37,6 @@ >> #include >> #include >> #include >> -#include >> >> #include "internal.h" >> >> @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode, >> struct blk_plug plug; >> unsigned long align = offset | iov_iter_alignment(iter); >> >> - /* >> - * Avoid references to bdev if not absolutely needed to give >> - * the early prefetch in the caller enough time. >> - */ >> - >> /* watch out for a 0 len io from a tricksy fs */ >> if (iov_iter_rw(iter) == READ && !count) >> return 0; >> -- >> 2.34.1 >>