* [PATCH] fs/direct-io: Remove linux/prefetch.h include
@ 2024-06-03 1:48 Youling Tang
2024-06-03 11:18 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: Youling Tang @ 2024-06-03 1:48 UTC (permalink / raw)
To: Alexander Viro, Christian Brauner
Cc: Jan Kara, linux-fsdevel, linux-kernel, Youling Tang
From: Youling Tang <tangyouling@kylinos.cn>
After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
in this file needs anything from `linux/prefetch.h`.
Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
---
fs/direct-io.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index b0aafe640fa4..bbd05f1a2145 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -37,7 +37,6 @@
#include <linux/rwsem.h>
#include <linux/uio.h>
#include <linux/atomic.h>
-#include <linux/prefetch.h>
#include "internal.h"
@@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
struct blk_plug plug;
unsigned long align = offset | iov_iter_alignment(iter);
- /*
- * Avoid references to bdev if not absolutely needed to give
- * the early prefetch in the caller enough time.
- */
-
/* watch out for a 0 len io from a tricksy fs */
if (iov_iter_rw(iter) == READ && !count)
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include
2024-06-03 1:48 [PATCH] fs/direct-io: Remove linux/prefetch.h include Youling Tang
@ 2024-06-03 11:18 ` Jan Kara
2024-07-24 7:33 ` Youling Tang
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kara @ 2024-06-03 11:18 UTC (permalink / raw)
To: Youling Tang
Cc: Alexander Viro, Christian Brauner, Jan Kara, linux-fsdevel,
linux-kernel, Youling Tang
On Mon 03-06-24 09:48:34, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
> in this file needs anything from `linux/prefetch.h`.
>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/direct-io.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/direct-io.c b/fs/direct-io.c
> index b0aafe640fa4..bbd05f1a2145 100644
> --- a/fs/direct-io.c
> +++ b/fs/direct-io.c
> @@ -37,7 +37,6 @@
> #include <linux/rwsem.h>
> #include <linux/uio.h>
> #include <linux/atomic.h>
> -#include <linux/prefetch.h>
>
> #include "internal.h"
>
> @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
> struct blk_plug plug;
> unsigned long align = offset | iov_iter_alignment(iter);
>
> - /*
> - * Avoid references to bdev if not absolutely needed to give
> - * the early prefetch in the caller enough time.
> - */
> -
> /* watch out for a 0 len io from a tricksy fs */
> if (iov_iter_rw(iter) == READ && !count)
> return 0;
> --
> 2.34.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include
2024-06-03 11:18 ` Jan Kara
@ 2024-07-24 7:33 ` Youling Tang
2024-07-26 7:16 ` Christian Brauner
0 siblings, 1 reply; 4+ messages in thread
From: Youling Tang @ 2024-07-24 7:33 UTC (permalink / raw)
To: Alexander Viro, Christian Brauner
Cc: linux-fsdevel, linux-kernel, Youling Tang, Jan Kara
Hi,
On 03/06/2024 19:18, Jan Kara wrote:
> On Mon 03-06-24 09:48:34, Youling Tang wrote:
>> From: Youling Tang <tangyouling@kylinos.cn>
>>
>> After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
>> in this file needs anything from `linux/prefetch.h`.
>>
>> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Sorry to bother you, but do we still need this patch?
Thanks,
Youling.
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
>
>> ---
>> fs/direct-io.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/fs/direct-io.c b/fs/direct-io.c
>> index b0aafe640fa4..bbd05f1a2145 100644
>> --- a/fs/direct-io.c
>> +++ b/fs/direct-io.c
>> @@ -37,7 +37,6 @@
>> #include <linux/rwsem.h>
>> #include <linux/uio.h>
>> #include <linux/atomic.h>
>> -#include <linux/prefetch.h>
>>
>> #include "internal.h"
>>
>> @@ -1121,11 +1120,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
>> struct blk_plug plug;
>> unsigned long align = offset | iov_iter_alignment(iter);
>>
>> - /*
>> - * Avoid references to bdev if not absolutely needed to give
>> - * the early prefetch in the caller enough time.
>> - */
>> -
>> /* watch out for a 0 len io from a tricksy fs */
>> if (iov_iter_rw(iter) == READ && !count)
>> return 0;
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs/direct-io: Remove linux/prefetch.h include
2024-07-24 7:33 ` Youling Tang
@ 2024-07-26 7:16 ` Christian Brauner
0 siblings, 0 replies; 4+ messages in thread
From: Christian Brauner @ 2024-07-26 7:16 UTC (permalink / raw)
To: Youling Tang
Cc: Alexander Viro, linux-fsdevel, linux-kernel, Youling Tang,
Jan Kara
On Wed, Jul 24, 2024 at 03:33:38PM GMT, Youling Tang wrote:
> Hi,
>
> On 03/06/2024 19:18, Jan Kara wrote:
> > On Mon 03-06-24 09:48:34, Youling Tang wrote:
> > > From: Youling Tang <tangyouling@kylinos.cn>
> > >
> > > After commit c22198e78d52 ("direct-io: remove random prefetches"), Nothing
> > > in this file needs anything from `linux/prefetch.h`.
> > >
> > > Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
> Sorry to bother you, but do we still need this patch?
It's in the vfs.misc pile for next merge window.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-26 7:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03 1:48 [PATCH] fs/direct-io: Remove linux/prefetch.h include Youling Tang
2024-06-03 11:18 ` Jan Kara
2024-07-24 7:33 ` Youling Tang
2024-07-26 7:16 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).