* [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
@ 2015-03-30 23:45 Joe Perches
2015-03-30 23:46 ` [PATCH 14/25] dcache: " Joe Perches
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
0 siblings, 2 replies; 4+ messages in thread
From: Joe Perches @ 2015-03-30 23:45 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, kvmarm, kvm, linux-omap, kvm-ppc,
virtualization, linux-fsdevel, linux-nfs, linux-ide,
kgdb-bugreport, linux-mm, linux-pm, netdev, alsa-devel, bridge,
netfilter-devel, coreteam, patches
Cc: linux-hexagon, linux-ia64, linux-mips, linuxppc-dev, linux-s390,
sparclinux, linux-scsi, linux-security-module
Joe Perches (25):
arm: Use bool function return values of true/false not 1/0
arm64: Use bool function return values of true/false not 1/0
hexagon: Use bool function return values of true/false not 1/0
ia64: Use bool function return values of true/false not 1/0
mips: Use bool function return values of true/false not 1/0
powerpc: Use bool function return values of true/false not 1/0
s390: Use bool function return values of true/false not 1/0
sparc: Use bool function return values of true/false not 1/0
tile: Use bool function return values of true/false not 1/0
unicore32: Use bool function return values of true/false not 1/0
x86: Use bool function return values of true/false not 1/0
virtio_console: Use bool function return values of true/false not 1/0
csiostor: Use bool function return values of true/false not 1/0
dcache: Use bool function return values of true/false not 1/0
nfsd: nfs4state: Use bool function return values of true/false not 1/0
include/linux: Use bool function return values of true/false not 1/0
sound: Use bool function return values of true/false not 1/0
rcu: tree_plugin: Use bool function return values of true/false not 1/0
sched: Use bool function return values of true/false not 1/0
ftrace: Use bool function return values of true/false not 1/0
slub: Use bool function return values of true/false not 1/0
bridge: Use bool function return values of true/false not 1/0
netfilter: Use bool function return values of true/false not 1/0
security: Use bool function return values of true/false not 1/0
sound: wm5100-tables: Use bool function return values of true/false not 1/0
arch/arm/include/asm/dma-mapping.h | 8 ++--
arch/arm/include/asm/kvm_emulate.h | 2 +-
arch/arm/mach-omap2/powerdomain.c | 14 +++---
arch/arm64/include/asm/dma-mapping.h | 2 +-
arch/hexagon/include/asm/dma-mapping.h | 2 +-
arch/ia64/include/asm/dma-mapping.h | 2 +-
arch/mips/include/asm/dma-mapping.h | 2 +-
arch/powerpc/include/asm/dcr-native.h | 2 +-
arch/powerpc/include/asm/dma-mapping.h | 4 +-
arch/powerpc/include/asm/kvm_book3s_64.h | 4 +-
arch/powerpc/sysdev/dcr.c | 2 +-
arch/s390/include/asm/dma-mapping.h | 2 +-
arch/sparc/mm/init_64.c | 8 ++--
arch/tile/include/asm/dma-mapping.h | 2 +-
arch/unicore32/include/asm/dma-mapping.h | 2 +-
arch/x86/include/asm/archrandom.h | 2 +-
arch/x86/include/asm/dma-mapping.h | 2 +-
arch/x86/include/asm/kvm_para.h | 2 +-
arch/x86/kvm/cpuid.h | 2 +-
arch/x86/kvm/vmx.c | 72 ++++++++++++++--------------
drivers/char/virtio_console.c | 2 +-
drivers/scsi/csiostor/csio_scsi.c | 4 +-
fs/dcache.c | 12 ++---
fs/nfsd/nfs4state.c | 2 +-
include/linux/blkdev.h | 2 +-
include/linux/ide.h | 2 +-
include/linux/kgdb.h | 2 +-
include/linux/mfd/db8500-prcmu.h | 2 +-
include/linux/mm.h | 2 +-
include/linux/power_supply.h | 8 ++--
include/linux/ssb/ssb_driver_extif.h | 2 +-
include/linux/ssb/ssb_driver_gige.h | 16 +++----
include/sound/soc.h | 4 +-
kernel/rcu/tree_plugin.h | 4 +-
kernel/sched/auto_group.h | 2 +-
kernel/sched/completion.c | 16 ++++---
kernel/trace/ftrace.c | 10 ++--
mm/slub.c | 12 ++---
net/bridge/br_private.h | 2 +-
net/ipv4/netfilter/ipt_ah.c | 2 +-
net/netfilter/ipset/ip_set_hash_ip.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++--
net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++--
net/netfilter/ipset/ip_set_hash_net.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netport.c | 8 ++--
net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++--
net/netfilter/xt_connlimit.c | 2 +-
net/netfilter/xt_hashlimit.c | 2 +-
net/netfilter/xt_ipcomp.c | 2 +-
security/apparmor/file.c | 8 ++--
security/apparmor/policy.c | 10 ++--
sound/soc/codecs/wm5100-tables.c | 12 ++---
55 files changed, 178 insertions(+), 176 deletions(-)
--
2.1.2
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 14/25] dcache: Use bool function return values of true/false not 1/0
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
@ 2015-03-30 23:46 ` Joe Perches
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2015-03-30 23:46 UTC (permalink / raw)
To: linux-kernel, Alexander Viro; +Cc: linux-fsdevel
Use the normal return values for bool functions
Signed-off-by: Joe Perches <joe@perches.com>
---
fs/dcache.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index d99736a..44b19a4 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -629,16 +629,16 @@ static inline bool fast_dput(struct dentry *dentry)
if (dentry->d_lockref.count > 1) {
dentry->d_lockref.count--;
spin_unlock(&dentry->d_lock);
- return 1;
+ return true;
}
- return 0;
+ return false;
}
/*
* If we weren't the last ref, we're done.
*/
if (ret)
- return 1;
+ return true;
/*
* Careful, careful. The reference count went down
@@ -667,7 +667,7 @@ static inline bool fast_dput(struct dentry *dentry)
/* Nothing to do? Dropping the reference was all we needed? */
if (d_flags == (DCACHE_REFERENCED | DCACHE_LRU_LIST) && !d_unhashed(dentry))
- return 1;
+ return true;
/*
* Not the fast normal case? Get the lock. We've already decremented
@@ -684,7 +684,7 @@ static inline bool fast_dput(struct dentry *dentry)
*/
if (dentry->d_lockref.count) {
spin_unlock(&dentry->d_lock);
- return 1;
+ return true;
}
/*
@@ -693,7 +693,7 @@ static inline bool fast_dput(struct dentry *dentry)
* set it to 1.
*/
dentry->d_lockref.count = 1;
- return 0;
+ return false;
}
--
2.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:46 ` [PATCH 14/25] dcache: " Joe Perches
@ 2015-03-31 0:07 ` Casey Schaufler
2015-03-31 0:14 ` Joe Perches
1 sibling, 1 reply; 4+ messages in thread
From: Casey Schaufler @ 2015-03-31 0:07 UTC (permalink / raw)
To: Joe Perches, linux-kernel, linux-arm-kernel, kvmarm, kvm,
linux-omap, kvm-ppc, virtualization, linux-fsdevel, linux-nfs,
linux-ide, kgdb-bugreport, linux-mm, linux-pm, netdev, alsa-devel,
bridge, netfilter-devel, coreteam, patches
Cc: linux-hexagon, linux-ia64, linux-mips, linuxppc-dev, linux-s390,
sparclinux, linux-scsi, linux-security-module
On 3/30/2015 4:45 PM, Joe Perches wrote:
> Joe Perches (25):
> arm: Use bool function return values of true/false not 1/0
> arm64: Use bool function return values of true/false not 1/0
> hexagon: Use bool function return values of true/false not 1/0
> ia64: Use bool function return values of true/false not 1/0
> mips: Use bool function return values of true/false not 1/0
> powerpc: Use bool function return values of true/false not 1/0
> s390: Use bool function return values of true/false not 1/0
> sparc: Use bool function return values of true/false not 1/0
> tile: Use bool function return values of true/false not 1/0
> unicore32: Use bool function return values of true/false not 1/0
> x86: Use bool function return values of true/false not 1/0
> virtio_console: Use bool function return values of true/false not 1/0
> csiostor: Use bool function return values of true/false not 1/0
> dcache: Use bool function return values of true/false not 1/0
> nfsd: nfs4state: Use bool function return values of true/false not 1/0
> include/linux: Use bool function return values of true/false not 1/0
> sound: Use bool function return values of true/false not 1/0
> rcu: tree_plugin: Use bool function return values of true/false not 1/0
> sched: Use bool function return values of true/false not 1/0
> ftrace: Use bool function return values of true/false not 1/0
> slub: Use bool function return values of true/false not 1/0
> bridge: Use bool function return values of true/false not 1/0
> netfilter: Use bool function return values of true/false not 1/0
> security: Use bool function return values of true/false not 1/0
> sound: wm5100-tables: Use bool function return values of true/false not 1/0
>
> arch/arm/include/asm/dma-mapping.h | 8 ++--
> arch/arm/include/asm/kvm_emulate.h | 2 +-
> arch/arm/mach-omap2/powerdomain.c | 14 +++---
> arch/arm64/include/asm/dma-mapping.h | 2 +-
> arch/hexagon/include/asm/dma-mapping.h | 2 +-
> arch/ia64/include/asm/dma-mapping.h | 2 +-
> arch/mips/include/asm/dma-mapping.h | 2 +-
> arch/powerpc/include/asm/dcr-native.h | 2 +-
> arch/powerpc/include/asm/dma-mapping.h | 4 +-
> arch/powerpc/include/asm/kvm_book3s_64.h | 4 +-
> arch/powerpc/sysdev/dcr.c | 2 +-
> arch/s390/include/asm/dma-mapping.h | 2 +-
> arch/sparc/mm/init_64.c | 8 ++--
> arch/tile/include/asm/dma-mapping.h | 2 +-
> arch/unicore32/include/asm/dma-mapping.h | 2 +-
> arch/x86/include/asm/archrandom.h | 2 +-
> arch/x86/include/asm/dma-mapping.h | 2 +-
> arch/x86/include/asm/kvm_para.h | 2 +-
> arch/x86/kvm/cpuid.h | 2 +-
> arch/x86/kvm/vmx.c | 72 ++++++++++++++--------------
> drivers/char/virtio_console.c | 2 +-
> drivers/scsi/csiostor/csio_scsi.c | 4 +-
> fs/dcache.c | 12 ++---
> fs/nfsd/nfs4state.c | 2 +-
> include/linux/blkdev.h | 2 +-
> include/linux/ide.h | 2 +-
> include/linux/kgdb.h | 2 +-
> include/linux/mfd/db8500-prcmu.h | 2 +-
> include/linux/mm.h | 2 +-
> include/linux/power_supply.h | 8 ++--
> include/linux/ssb/ssb_driver_extif.h | 2 +-
> include/linux/ssb/ssb_driver_gige.h | 16 +++----
> include/sound/soc.h | 4 +-
> kernel/rcu/tree_plugin.h | 4 +-
> kernel/sched/auto_group.h | 2 +-
> kernel/sched/completion.c | 16 ++++---
> kernel/trace/ftrace.c | 10 ++--
> mm/slub.c | 12 ++---
> net/bridge/br_private.h | 2 +-
> net/ipv4/netfilter/ipt_ah.c | 2 +-
> net/netfilter/ipset/ip_set_hash_ip.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipmark.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipport.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipportip.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_ipportnet.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_net.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_netiface.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_netport.c | 8 ++--
> net/netfilter/ipset/ip_set_hash_netportnet.c | 8 ++--
> net/netfilter/xt_connlimit.c | 2 +-
> net/netfilter/xt_hashlimit.c | 2 +-
> net/netfilter/xt_ipcomp.c | 2 +-
> security/apparmor/file.c | 8 ++--
> security/apparmor/policy.c | 10 ++--
> sound/soc/codecs/wm5100-tables.c | 12 ++---
Why, and why these in particular?
> 55 files changed, 178 insertions(+), 176 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
@ 2015-03-31 0:14 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2015-03-31 0:14 UTC (permalink / raw)
To: Casey Schaufler
Cc: linux-kernel, linux-arm-kernel, kvmarm, kvm, linux-omap, kvm-ppc,
virtualization, linux-fsdevel, linux-nfs, linux-ide,
kgdb-bugreport, linux-mm, linux-pm, netdev, alsa-devel, bridge,
netfilter-devel, coreteam, patches, linux-hexagon, linux-ia64,
linux-mips, linuxppc-dev, linux-s390, sparclinux, linux-scsi,
linux-security-module
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote:
> On 3/30/2015 4:45 PM, Joe Perches wrote:
> > Joe Perches (25):
> > arm: Use bool function return values of true/false not 1/0
[etc...]
> Why, and why these in particular?
bool functions are probably better returning
bool values instead of 1 and 0.
Especially when the functions intermix returning
returning 1/0 and true/false.
(there are only a couple of those though)
These are all the remaining instances in the
kernel tree.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-31 0:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 23:45 [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-30 23:46 ` [PATCH 14/25] dcache: " Joe Perches
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
2015-03-31 0:14 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).