From: Yann Droneaud <ydroneaud@opteya.com>
To: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Yann Droneaud <ydroneaud@opteya.com>
Subject: [PATCH v1 0/3] No more seq_file pre-allocation
Date: Mon, 1 Jun 2015 23:32:12 +0200 [thread overview]
Message-ID: <cover.1433193673.git.ydroneaud@opteya.com> (raw)
Hi,
Please find a revised patchset to remove support for
passing pre-allocated struct seq_file to seq_open().
Such feature is undocumented and prone to error.
In particular, if seq_release() is used in release
handler, it will kfree() a pointer which was not
allocated by seq_open().
So, please find a patchset that drop the support for
pre-allocated struct seq_file: it's only of use in
proc_namespace.c and can be easily replaced by using
seq_open_private()/seq_release_private().
Additionally, it documents the use of file->private_data
to hold pointer to struct seq_file by seq_open().
Changes from v0 [0]:
- convert kmalloc() + memset() to kzalloc()
- revised a bit commit messages
[0] [PATCH 0/3] seq_file allocation in seq_open()
http://lkml.kernel.org/r/cover.1430777196.git.ydroneaud@opteya.com
http://lkml.kernel.org/g/cover.1430777196.git.ydroneaud@opteya.com
Yann Droneaud (3):
fs: use seq_open_private() for proc_mounts
fs: allocate structure unconditionally in seq_open()
fs: documents seq_open()'s usage of file->private_data
fs/mount.h | 3 ---
fs/namespace.c | 6 +++---
fs/proc_namespace.c | 34 ++++++++++++++++------------------
fs/seq_file.c | 19 +++++++++++--------
4 files changed, 30 insertions(+), 32 deletions(-)
--
2.4.2
next reply other threads:[~2015-06-01 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 21:32 Yann Droneaud [this message]
2015-06-01 21:32 ` [PATCH v1 1/3] fs: use seq_open_private() for proc_mounts Yann Droneaud
2015-06-01 21:32 ` [PATCH v1 2/3] fs: allocate structure unconditionally in seq_open() Yann Droneaud
2015-06-01 21:32 ` [PATCH v1 3/3] fs: documents seq_open()'s usage of file->private_data Yann Droneaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1433193673.git.ydroneaud@opteya.com \
--to=ydroneaud@opteya.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).