linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 0/2] fs: allow cross-vfsmount reflink/dedupe
Date: Fri, 18 Feb 2022 09:38:12 -0500	[thread overview]
Message-ID: <cover.1645194730.git.josef@toxicpanda.com> (raw)

Hello,

These patches allow for cross vfsmount reflink/dedupe for everybody and removes
the duplicate checks in btrfs so we can allow it as well.  This limitation seems
to have been copied around from the original implementation from btrfs, but
makes little sense as we just need to make sure both files are on the same super
block.

Btrfs usage across all the distro's I'm aware of regularly use the pattern of
mounting subvolumes for different areas of the file system, and so we need to
allow reflink to happen over vfsmount as a matter of practicality.  It makes no
sense to make cp --reflink=always not work if you are copying something from say
/var to /home if they're differently mounted subvolumes.

The only change since v1 has been adding the Reviewed-by's for the VFS patch,
and then adding an ASSERT() to the btrfs patch to make sure we catch any changes
to this path.

Al if you have no objections we can send this through the btrfs tree.  Thanks,

Josef

Josef Bacik (2):
  btrfs: remove the cross file system checks from remap
  fs: allow cross-vfsmount reflink/dedupe

 fs/btrfs/reflink.c | 4 +---
 fs/ioctl.c         | 4 ----
 fs/remap_range.c   | 7 +------
 3 files changed, 2 insertions(+), 13 deletions(-)

-- 
2.26.3


             reply	other threads:[~2022-02-18 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 14:38 Josef Bacik [this message]
2022-02-18 14:38 ` [PATCH v2 1/2] btrfs: remove the cross file system checks from remap Josef Bacik
2022-02-18 14:39   ` Nikolay Borisov
2022-02-18 14:38 ` [PATCH v2 2/2] fs: allow cross-vfsmount reflink/dedupe Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1645194730.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).