linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Naohiro Aota <naohiro.aota@wdc.com>
To: linux-btrfs@vger.kernel.org
Cc: johannes.thumshirn@wdc.com, linux-fsdevel@vger.kernel.org,
	viro@zeniv.linux.org.uk, david@fromorbit.com,
	Naohiro Aota <naohiro.aota@wdc.com>
Subject: [PATCH 0/4] protect relocation with sb_start_write
Date: Fri, 11 Mar 2022 16:38:01 +0900	[thread overview]
Message-ID: <cover.1646983176.git.naohiro.aota@wdc.com> (raw)

This series is a follow-up to the series below. The old series added
an assertion to btrfs_relocate_chunk() to check if it is protected
with sb_start_write(). However, it revealed another location we need
to add sb_start_write() [1].

https://lore.kernel.org/linux-btrfs/cover.1645157220.git.naohiro.aota@wdc.com/T/

[1] https://lore.kernel.org/linux-btrfs/cover.1645157220.git.naohiro.aota@wdc.com/T/#e06eecc07ce1cd1e45bfd30a374bd2d15b4fd76d8

Patches 1 and 2 add sb_{start,end}_write() to the resumed async
balancing and device addition.

Patches 3 and 4 add an ASSERT to catch a future error.

Note: I added Fixes tag as "5accdf82ba25 ("fs: Improve filesystem
freezing handling")" considering that sb_start_write() is missing from
the introduction of it. But, I'm not sure this commit is correct or
not.

Naohiro Aota (4):
  btrfs: mark resumed async balance as writing
  btrfs: mark device addition as sb_writing
  fs: add check functions for sb_start_{write,pagefault,intwrite}
  btrfs: assert that relocation is protected with sb_start_write()

 fs/btrfs/ioctl.c   |  2 ++
 fs/btrfs/volumes.c |  5 +++++
 include/linux/fs.h | 20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)

-- 
2.35.1


             reply	other threads:[~2022-03-11  7:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  7:38 Naohiro Aota [this message]
2022-03-11  7:38 ` [PATCH 1/4] btrfs: mark resumed async balance as writing Naohiro Aota
2022-03-11 14:08   ` Filipe Manana
2022-03-14  2:29     ` Naohiro Aota
2022-03-14 11:25       ` Filipe Manana
2022-03-11  7:38 ` [PATCH 2/4] btrfs: mark device addition as sb_writing Naohiro Aota
2022-03-11 14:21   ` Filipe Manana
2022-03-14  2:31     ` Naohiro Aota
2022-03-11  7:38 ` [PATCH 3/4] fs: add check functions for sb_start_{write,pagefault,intwrite} Naohiro Aota
2022-03-11 14:28   ` Filipe Manana
2022-03-11  7:38 ` [PATCH 4/4] btrfs: assert that relocation is protected with sb_start_write() Naohiro Aota
2022-03-11 14:33   ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1646983176.git.naohiro.aota@wdc.com \
    --to=naohiro.aota@wdc.com \
    --cc=david@fromorbit.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).