From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: Jan Kara <jack@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
linux-ntfs-dev@lists.sourceforge.net,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCHv3 0/4] submit_bh: Drop unnecessary return value
Date: Thu, 18 Aug 2022 10:34:36 +0530 [thread overview]
Message-ID: <cover.1660788334.git.ritesh.list@gmail.com> (raw)
submit_bh/submit_bh_wbc are non-blocking functions which just submits
the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait
on buffer till I/O completion and then check buffer head's b_state field
to know if there was any I/O error.
Hence there is no need for these functions to have any return type.
Even now they always returns 0. Hence drop the return value and make
their return type as void to avoid any confusion.
PATCHv2 -> PATCHv3
===================
1. Rebased on top of the latest 6.0-rc1 release.
Recently REQ_OP_** req operations and REQ_** flags were combined as one
parameter (blk_opf_t type) to submit_bh() API.
2. Since the patch series remains trivial on rebase, I have retained the
reviewed-by from Jan and Christoph.
RFC -> PATCHv2
===============
1. Added Patch-2 to fix ntfs_submit_bh_for_read() caller.
2. Added Reviewed-by from Christoph.
Ritesh Harjani (IBM) (4):
jbd2: Drop useless return value of submit_bh
fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read
fs/buffer: Drop useless return value of submit_bh
fs/buffer: Make submit_bh & submit_bh_wbc return type as void
fs/buffer.c | 23 ++++++++++-------------
fs/jbd2/commit.c | 10 ++++------
fs/jbd2/journal.c | 9 ++++-----
fs/ntfs/file.c | 4 ++--
include/linux/buffer_head.h | 2 +-
5 files changed, 21 insertions(+), 27 deletions(-)
--
2.35.3
next reply other threads:[~2022-08-18 5:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 5:04 Ritesh Harjani (IBM) [this message]
2022-08-18 5:04 ` [PATCHv3 1/4] jbd2: Drop useless return value of submit_bh Ritesh Harjani (IBM)
2022-08-18 5:04 ` [PATCHv3 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read Ritesh Harjani (IBM)
2022-08-18 5:04 ` [PATCHv3 3/4] fs/buffer: Drop useless return value of submit_bh Ritesh Harjani (IBM)
2022-08-18 14:15 ` Jan Kara
2022-08-18 5:04 ` [PATCHv3 4/4] fs/buffer: Make submit_bh & submit_bh_wbc return type as void Ritesh Harjani (IBM)
2022-09-29 14:58 ` [PATCHv3 0/4] submit_bh: Drop unnecessary return value Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1660788334.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).