From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.avm.de (mail.avm.de [212.42.244.120]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AD773E0C73; Tue, 3 Mar 2026 10:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.42.244.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772535577; cv=none; b=O0LujDgr1HKenAia15kVTlKlJvADklkjOa1mfneJzQw/abwdh7AyUpGDoY4OOdkY+ToLeXvDZ+s/TEwSCYjL6yOLlnGcqe1DloNZtCFoj1v/wT5z9CJxJx+aiWGj9ZWVv5leA6i/ePMy/5suF0y3nvy8wvXsmAGDyYLNsjmvwyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772535577; c=relaxed/simple; bh=fxfNMY1/bETtKv/qGV2veO9GsO00dZq3D5BMTLQiLuY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eGrFwUmjy7DLNn1l2DGPgvi4yRurspRFW++8OlBecArKdGc1Am1oKnwVW6fLNlUrFxR2JC0OuUYt03j9A9gGSlwoku3wNduSq7fnNVZwVtwA4GYWuEhd2vZ2e8jikgfJRiZynAXta7R0qbb0Uc0oMUIpflCjxSDQbLaosTVogks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=avm.de; spf=pass smtp.mailfrom=avm.de; arc=none smtp.client-ip=212.42.244.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=avm.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=avm.de Received: from [212.42.244.71] (helo=mail.avm.de) by mail.avm.de with ESMTP (eXpurgate 4.55.2) (envelope-from ) id 69a6bf0c-0473-7f0000032729-7f0000019b32-1 for ; Tue, 03 Mar 2026 11:59:24 +0100 Received: from mail-auth.avm.de (dovecot-mx-01.avm.de [212.42.244.71]) by mail.avm.de (Postfix) with ESMTPS; Tue, 3 Mar 2026 11:59:24 +0100 (CET) From: Philipp Hahn To: Namjae Jeon , Sungjong Seo , Yuezhang Mo Cc: Philipp Hahn , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] exfat: Fix 2 issues found by static code analysis Date: Tue, 3 Mar 2026 11:59:13 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: FRITZ! Technology GmbH, Berlin, Germany Content-Transfer-Encoding: 8bit X-purgate-ID: 149429::1772535564-CD7F895F-0275334D/0/0 X-purgate-type: clean X-purgate-size: 696 X-purgate-Ad: Categorized by eleven eXpurgate (R) https://www.eleven.de X-purgate: This mail is considered clean (visit https://www.eleven.de for further information) X-purgate: clean Hello, I'm going through our list of issues found by static code analysis using Klocwork. It found two issues worth fixing: 1. The 1st seems to be a real bug due to C's integer coercion, where the inverted bitmask `s_blocksize` gets 0 extended. 2. The 2nd might just be a dead variable assignment, but maybe `num_clusters` is supposed to be returned or stored elsewhere? I hope my alaysis is correct. If yes, please apply. Thank you. Philipp Hahn (2): exfat: Fix bitwise operation having different size exfat: Drop dead assignment of num_clusters fs/exfat/dir.c | 2 +- fs/exfat/inode.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) -- 2.43.0