From: "Jürg Billeter" <j@bitron.ch>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/3] fuse: use folio_end_read
Date: Sat, 10 Aug 2024 14:24:24 +0200 [thread overview]
Message-ID: <d0844e7465a12eef0e2998b5f44b350ee9e185be.camel@bitron.ch> (raw)
In-Reply-To: <20240809162221.2582364-3-willy@infradead.org>
On Fri, 2024-08-09 at 17:22 +0100, Matthew Wilcox (Oracle) wrote:
> part three
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> fs/fuse/file.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 2b5533e41a62..f39456c65ed7 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -937,9 +937,7 @@ static void fuse_readpages_end(struct fuse_mount
> *fm, struct fuse_args *args,
> for (i = 0; i < ap->num_pages; i++) {
> struct folio *folio = page_folio(ap->pages[i]);
>
> - if (!err)
> - folio_mark_uptodate(folio);
> - folio_unlock(folio);
> + folio_end_read(folio, !err);
> folio_put(folio);
> }
> if (ia->ff)
Reverting this part is sufficient to fix the issue for me.
Cheers,
Jürg
next prev parent reply other threads:[~2024-08-10 12:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 15:53 [REGRESSION] fuse: copy_file_range() fails with EIO Jürg Billeter
2024-08-09 16:03 ` Matthew Wilcox
2024-08-09 16:22 ` [PATCH 1/3] fuse: remove call to SetPageError Matthew Wilcox (Oracle)
2024-08-09 16:22 ` [PATCH 2/3] fuse: Use a folio instead of a page Matthew Wilcox (Oracle)
2024-08-09 16:22 ` [PATCH 3/3] fuse: use folio_end_read Matthew Wilcox (Oracle)
2024-08-10 12:24 ` Jürg Billeter [this message]
2024-08-20 12:57 ` Jürg Billeter
2024-08-20 13:50 ` Matthew Wilcox
2024-08-22 11:58 ` Miklos Szeredi
2024-08-22 12:25 ` Matthew Wilcox
2024-08-10 5:56 ` [REGRESSION] fuse: copy_file_range() fails with EIO Jürg Billeter
2024-08-10 15:12 ` Matthew Wilcox
2024-08-22 13:04 ` Miklos Szeredi
2024-08-22 13:12 ` Jürg Billeter
2024-08-22 13:14 ` Miklos Szeredi
2024-08-22 13:32 ` Miklos Szeredi
2024-08-22 14:14 ` Jürg Billeter
2024-08-29 9:27 ` Marcel Ziswiler
2024-08-29 9:30 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0844e7465a12eef0e2998b5f44b350ee9e185be.camel@bitron.ch \
--to=j@bitron.ch \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).