From: Dave Hansen <dave.hansen@intel.com>
To: j.granados@samsung.com, Luis Chamberlain <mcgrof@kernel.org>,
willy@infradead.org, josh@joshtriplett.org,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Guo Ren <guoren@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-ia64@vger.kernel.org, linux-csky@vger.kernel.org
Subject: Re: [PATCH 3/8] arch/x86: Remove sentinel elem from ctl_table arrays
Date: Wed, 6 Sep 2023 07:45:09 -0700 [thread overview]
Message-ID: <d0d30ad4-7837-b0c4-39f4-3e317e35a41b@intel.com> (raw)
In-Reply-To: <20230906-jag-sysctl_remove_empty_elem_arch-v1-3-3935d4854248@samsung.com>
On 9/6/23 03:03, Joel Granados via B4 Relay wrote:
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> Remove sentinel element from sld_sysctl and itmt_kern_table.
There's a *LOT* of content to read for a reviewer to figure out what's
going on here between all the links. I would have appreciated one more
sentence here, maybe:
This is now safe because the sysctl registration code
(register_sysctl()) implicitly uses ARRAY_SIZE() in addition
to checking for a sentinel.
That needs to be more prominent _somewhere_. Maybe here, or maybe in
the cover letter, but _somewhere_.
That said, feel free to add this to the two x86 patches:
Acked-by: Dave Hansen <dave.hansen@linux.intel.com> # for x86
next prev parent reply other threads:[~2023-09-06 14:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 10:03 [PATCH 0/8] sysctl: Remove sentinel elements from arch Joel Granados via B4 Relay
2023-09-06 10:03 ` [PATCH 1/8] S390: Remove sentinel elem from ctl_table arrays Joel Granados via B4 Relay
2023-09-07 8:51 ` Heiko Carstens
2023-09-07 9:08 ` Alexander Gordeev
2023-09-06 10:03 ` [PATCH 2/8] arm: " Joel Granados via B4 Relay
2023-09-06 10:03 ` [PATCH 3/8] arch/x86: " Joel Granados via B4 Relay
2023-09-06 14:45 ` Dave Hansen [this message]
2023-09-06 21:58 ` Ingo Molnar
2023-09-07 8:24 ` Joel Granados
2023-09-07 7:38 ` Joel Granados
2023-09-06 10:03 ` [PATCH 4/8] x86 vdso: rm sentinel element from ctl_table array Joel Granados via B4 Relay
2023-09-06 10:03 ` [PATCH 5/8] riscv: Remove " Joel Granados via B4 Relay
2023-09-06 10:03 ` [PATCH 6/8] powerpc: Remove sentinel element from ctl_table arrays Joel Granados via B4 Relay
2023-09-06 10:03 ` [PATCH 7/8] ia64: Remove sentinel element from ctl_table array Joel Granados via B4 Relay
2023-09-06 10:03 ` [PATCH 8/8] c-sky: rm sentinel element from ctl_talbe array Joel Granados via B4 Relay
2023-09-08 9:01 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d30ad4-7837-b0c4-39f4-3e317e35a41b@intel.com \
--to=dave.hansen@intel.com \
--cc=agordeev@linux.ibm.com \
--cc=aou@eecs.berkeley.edu \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=j.granados@samsung.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).