From: Bart Van Assche <bvanassche@acm.org>
To: Kanchan Joshi <joshi.k@samsung.com>,
axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com, brauner@kernel.org,
jack@suse.cz, jaegeuk@kernel.org, jlayton@kernel.org,
chuck.lever@oracle.com
Cc: linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
gost.dev@samsung.com, vishak.g@samsung.com,
javier.gonz@samsung.com
Subject: Re: [PATCH v4 1/5] fs, block: refactor enum rw_hint
Date: Mon, 26 Aug 2024 10:44:00 -0700 [thread overview]
Message-ID: <d0e017ac-8367-4bb8-9b7f-d72dd068fdb1@acm.org> (raw)
In-Reply-To: <20240826170606.255718-2-joshi.k@samsung.com>
On 8/26/24 10:06 AM, Kanchan Joshi wrote:
> Change i_write_hint (in inode), bi_write_hint (in bio) and write_hint
> (in request) to use u8 data-type rather than this enum.
That sounds fishy to me. Why to increase the size of this enum? Why to
reduce the ability of the compiler to perform type checking? I think
this needs to be motivated clearly in the patch description.
Bart.
next prev parent reply other threads:[~2024-08-26 17:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240826171409epcas5p306ba210a9815e202556778a4c105b440@epcas5p3.samsung.com>
2024-08-26 17:06 ` [PATCH v4 0/5] Write-placement hints and FDP Kanchan Joshi
[not found] ` <CGME20240826171413epcas5p3f62c2cc57b50d6df8fa66af5fe5996c5@epcas5p3.samsung.com>
2024-08-26 17:06 ` [PATCH v4 1/5] fs, block: refactor enum rw_hint Kanchan Joshi
2024-08-26 17:44 ` Bart Van Assche [this message]
2024-08-27 5:12 ` Kanchan Joshi
2024-08-30 12:17 ` Bart Van Assche
2024-09-02 5:18 ` Kanchan Joshi
[not found] ` <CGME20240826171417epcas5p1c6dbe318c43324116647dae2129b7eb3@epcas5p1.samsung.com>
2024-08-26 17:06 ` [PATCH v4 2/5] fcntl: rename rw_hint_* to rw_life_hint_* Kanchan Joshi
[not found] ` <CGME20240826171422epcas5p2fa8f07dfee9395745f1833a17fd89ae0@epcas5p2.samsung.com>
2024-08-26 17:06 ` [PATCH v4 3/5] fcntl: add F_{SET/GET}_RW_HINT_EX Kanchan Joshi
[not found] ` <CGME20240826171426epcas5p13c5ffabd6a05ee357bf4e9f78bc5de44@epcas5p1.samsung.com>
2024-08-26 17:06 ` [PATCH v4 4/5] sd: limit to use write life hints Kanchan Joshi
[not found] ` <CGME20240826171430epcas5p3d8e34a266ced7b3ea0df2a11b83292ae@epcas5p3.samsung.com>
2024-08-26 17:06 ` [PATCH v4 5/5] nvme: enable FDP support Kanchan Joshi
2024-09-06 16:04 ` Keith Busch
2024-09-10 9:25 ` Kanchan Joshi
2024-08-30 11:59 ` [PATCH v4 0/5] Write-placement hints and FDP Javier González
2024-09-03 14:28 ` Kanchan Joshi
2024-09-03 14:35 ` Christian Brauner
2024-09-04 14:57 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0e017ac-8367-4bb8-9b7f-d72dd068fdb1@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=javier.gonz@samsung.com \
--cc=jlayton@kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).