From: Ritesh Harjani <riteshh@linux.ibm.com>
To: linux-ext4@vger.kernel.org
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.com>,
tytso@mit.edu, "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [RFC 09/20] ext4: mballoc: Make ext4_mb_use_preallocated() return type as bool
Date: Fri, 1 May 2020 11:59:51 +0530 [thread overview]
Message-ID: <d10718387fdfbcc6dd48ce2fd646715b7bd23a63.1588313626.git.riteshh@linux.ibm.com> (raw)
In-Reply-To: <cover.1588313626.git.riteshh@linux.ibm.com>
Change return type of function ext4_mb_use_preallocated() to bool to
better reflect what this function can return.
There should be no functionality change in this patch.
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
fs/ext4/mballoc.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 10f295c61ccb..6e7232fd109e 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3461,7 +3461,7 @@ ext4_mb_check_group_pa(ext4_fsblk_t goal_block,
/*
* search goal blocks in preallocated space
*/
-static noinline_for_stack int
+static noinline_for_stack bool
ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
{
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
@@ -3473,7 +3473,7 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
/* only data can be preallocated */
if (!(ac->ac_flags & EXT4_MB_HINT_DATA))
- return 0;
+ return false;
/* first, try per-file preallocation */
rcu_read_lock();
@@ -3500,7 +3500,7 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
spin_unlock(&pa->pa_lock);
ac->ac_criteria = 10;
rcu_read_unlock();
- return 1;
+ return true;
}
spin_unlock(&pa->pa_lock);
}
@@ -3508,12 +3508,12 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
/* can we use group allocation? */
if (!(ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC))
- return 0;
+ return false;
/* inode may have no locality group for some reason */
lg = ac->ac_lg;
if (lg == NULL)
- return 0;
+ return false;
order = fls(ac->ac_o_ex.fe_len) - 1;
if (order > PREALLOC_TB_SIZE - 1)
/* The max size of hash table is PREALLOC_TB_SIZE */
@@ -3542,9 +3542,9 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
if (cpa) {
ext4_mb_use_group_pa(ac, cpa);
ac->ac_criteria = 20;
- return 1;
+ return true;
}
- return 0;
+ return false;
}
/*
--
2.21.0
next prev parent reply other threads:[~2020-05-01 6:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 6:29 [RFC 00/20] ext4: Fix ENOSPC error, improve mballoc dbg, other cleanups Ritesh Harjani
2020-05-01 6:29 ` [RFC 01/20] ext4: mballoc: Refactor ext4_mb_discard_preallocations() Ritesh Harjani
2020-05-01 6:29 ` [RFC 02/20] ext4: Introduce percpu seq counter for freeing blocks(PA) to avoid ENOSPC err Ritesh Harjani
2020-05-01 18:31 ` Paul E. McKenney
2020-05-04 22:34 ` Ritesh Harjani
2020-05-05 0:36 ` Paul E. McKenney
2020-05-01 6:29 ` [RFC 03/20] ext4: mballoc: Do print bb_free info even when it is 0 Ritesh Harjani
2020-05-01 6:29 ` [RFC 04/20] ext4: mballoc: Refactor ext4_mb_show_ac() Ritesh Harjani
2020-05-01 6:29 ` [RFC 05/20] ext4: mballoc: Add more mb_debug() msgs Ritesh Harjani
2020-05-01 6:29 ` [RFC 06/20] ext4: mballoc: Correct the mb_debug() format specifier for pa_len var Ritesh Harjani
2020-05-01 6:29 ` [RFC 07/20] ext4: mballoc: Fix few other format specifier in mb_debug() Ritesh Harjani
2020-05-01 6:29 ` [RFC 08/20] ext4: mballoc: Simplify error handling in ext4_init_mballoc() Ritesh Harjani
2020-05-01 6:29 ` Ritesh Harjani [this message]
2020-05-01 6:29 ` [RFC 10/20] ext4: mballoc: Remove EXT4_MB_HINT_GOAL_ONLY and it's related code Ritesh Harjani
2020-05-01 6:29 ` [RFC 11/20] ext4: mballoc: Refactor code inside DOUBLE_CHECK into separate function Ritesh Harjani
2020-05-01 6:29 ` [RFC 12/20] ext4: mballoc: Fix possible NULL ptr dereference from mb_cmp_bitmaps() Ritesh Harjani
2020-05-01 6:29 ` [RFC 13/20] ext4: mballoc: Don't BUG if kmalloc or read blk bitmap fail for DOUBLE_CHECK Ritesh Harjani
2020-05-01 6:29 ` [RFC 14/20] ext4: balloc: Use task_pid_nr() helper Ritesh Harjani
2020-05-01 6:29 ` [RFC 15/20] ext4: Use BIT() macro for BH_** state bits Ritesh Harjani
2020-05-01 6:29 ` [RFC 16/20] ext4: Improve ext_debug() msg in case of block allocation failure Ritesh Harjani
2020-05-01 6:29 ` [RFC 17/20] ext4: Replace EXT_DEBUG with __maybe_unused in ext4_ext_handle_unwritten_extents() Ritesh Harjani
2020-05-01 6:30 ` [RFC 18/20] ext4: mballoc: Make mb_debug() implementation to use pr_debug() Ritesh Harjani
2020-05-01 6:30 ` [RFC 19/20] ext4: Make ext_debug() " Ritesh Harjani
2020-05-01 6:30 ` [RFC 20/20] ext4: Add process name and pid in ext4_msg() Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d10718387fdfbcc6dd48ce2fd646715b7bd23a63.1588313626.git.riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).