From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:59970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbdJVPQZ (ORCPT ); Sun, 22 Oct 2017 11:16:25 -0400 Subject: Re: [f2fs-dev] [PATCH] f2fs: turn quota off when error occurs To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20171020155337.5354-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Sun, 22 Oct 2017 23:16:17 +0800 MIME-Version: 1.0 In-Reply-To: <20171020155337.5354-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2017/10/20 23:53, Jaegeuk Kim wrote: > Before changing readonly, it needs to turn quota off. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/checkpoint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 201608281681..ff74665d7f2d 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -29,6 +29,7 @@ struct kmem_cache *inode_entry_slab; > void f2fs_stop_checkpoint(struct f2fs_sb_info *sbi, bool end_io) > { > set_ckpt_flags(sbi, CP_ERROR_FLAG); > + f2fs_quota_off_umount(sb); > sbi->sb->s_flags |= MS_RDONLY; > if (!end_io) Oh, f2fs_stop_checkpoint can be called from end_io, how about adding f2fs_quota_off_umount here? Thanks, > f2fs_flush_merged_writes(sbi); >