From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
adilger@dilger.ca, martin.petersen@oracle.com,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 9/9] nvme: add support for streams and directives
Date: Mon, 26 Jun 2017 07:56:22 -0600 [thread overview]
Message-ID: <d2dcae41-d0b2-71a7-a63d-b7ef25ae47d2@kernel.dk> (raw)
In-Reply-To: <20170626095907.GG14057@infradead.org>
On 06/26/2017 03:59 AM, Christoph Hellwig wrote:
> Looks mostly good,
>
> but two nit-picks:
>
> - can we keep a module option to disable streams, or in fact for
> now maybe to explicitly enable it? I expect this to be interesting
> at least for the first devices that implement it. Also given that
> it needs to be explicitly enabled I would expect some overhead of
> just enabling it when never used
Fine with me, I can add the 'streams' parameter back, but just default
it to false.
> - do we even need the < 4 streams fallback now that they are global
> instead of per-ns instead of just disabling the feature for now?
Maybe the device only supports 2? or 3?
--
Jens Axboe
next prev parent reply other threads:[~2017-06-26 13:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 0:21 [PATCHSET v9] Add support for write life time hints Jens Axboe
2017-06-21 0:21 ` [PATCH 1/9] fs: add fcntl() interface for setting/getting " Jens Axboe
2017-06-26 9:51 ` Christoph Hellwig
2017-06-26 13:55 ` Jens Axboe
2017-06-26 16:09 ` Darrick J. Wong
2017-06-26 16:29 ` Jens Axboe
2017-06-21 0:21 ` [PATCH 2/9] block: add support for write hints in a bio Jens Axboe
2017-06-26 9:52 ` Christoph Hellwig
2017-06-21 0:22 ` [PATCH 3/9] blk-mq: expose stream write hints through debugfs Jens Axboe
2017-06-26 9:52 ` Christoph Hellwig
2017-06-21 0:22 ` [PATCH 4/9] fs: add O_DIRECT support for sending down write life time hints Jens Axboe
2017-06-26 9:55 ` Christoph Hellwig
2017-06-26 14:12 ` Jens Axboe
2017-06-21 0:22 ` [PATCH 5/9] fs: add support for buffered writeback to pass down write hints Jens Axboe
2017-06-21 0:22 ` [PATCH 6/9] ext4: add support for passing in write hints for buffered writes Jens Axboe
2017-06-21 0:22 ` [PATCH 7/9] xfs: " Jens Axboe
2017-06-21 1:35 ` Darrick J. Wong
2017-06-21 1:46 ` Jens Axboe
2017-06-26 9:56 ` Christoph Hellwig
2017-06-26 14:16 ` Jens Axboe
2017-06-21 0:22 ` [PATCH 8/9] btrfs: " Jens Axboe
2017-06-21 0:22 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe
2017-06-26 9:59 ` Christoph Hellwig
2017-06-26 13:56 ` Jens Axboe [this message]
2017-06-26 19:36 ` Andreas Dilger
2017-06-26 19:39 ` Jens Axboe
2017-06-27 14:11 ` Christoph Hellwig
2017-06-27 14:16 ` Jens Axboe
2017-06-27 14:44 ` Christoph Hellwig
2017-06-27 14:46 ` Jens Axboe
2017-06-27 14:56 ` Jens Axboe
2017-06-26 17:52 ` Martin K. Petersen
2017-06-26 18:00 ` Jens Axboe
2017-06-21 1:30 ` [PATCHSET v9] Add support for write life time hints Martin K. Petersen
2017-06-21 1:45 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2017-06-26 15:37 [PATCHSET v10] " Jens Axboe
2017-06-26 15:38 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe
2017-06-19 17:04 [PATCHSET v8] Add support for write life time hints Jens Axboe
2017-06-19 17:05 ` [PATCH 9/9] nvme: add support for streams and directives Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2dcae41-d0b2-71a7-a63d-b7ef25ae47d2@kernel.dk \
--to=axboe@kernel.dk \
--cc=adilger@dilger.ca \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).