From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD0114EC47 for ; Wed, 25 Sep 2024 06:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727244069; cv=none; b=V5fCYWzFLegTh1v61JvMG8iSHOLTnEObmFcVeDqM89HWsEKqAT1VugCX2i7T98jR3QAgW5slbNxWikhlM8naBby2wjulsuLg8EdENhigne1Dt+NvCWid6k2daxTjZ5TARs1R+PfhUHWdsTEK1jiaPKUR6/cYF0nLWQDLjJq+9TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727244069; c=relaxed/simple; bh=LWwfTLGgsAaqaffWWmZAwmcBBki1MJezhqYcpwgfKE8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k2XXrEyFJwkM5YbB/PRYil4HO95hbIgSDBsny25+HdJUJbhFNH7VbbZ0tunXvr+UsJKgb8bogSFxAxkXbCYoa11S50eI0q36Mq5NmrOvbpO0Wv/qMbn5A+GJZ4XDxHiZNcVfNA+cA4mKlyKh7HXJiwtAC4pUi0jYCAgyuPJyGZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=TAtvOmmF; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="TAtvOmmF" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cd74c0d16so60409025e9.1 for ; Tue, 24 Sep 2024 23:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1727244063; x=1727848863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lDIjHlwQvn0FXZAsTPQMYoaFJJr2KcEtONsfmP4GO8E=; b=TAtvOmmFHnbtP6ZSFe2Q5/4kqZ7s8GZ1hwy0e9UVfwicUvweOxKC98fM4MEkyMfA/s OaYlgLoUyNJ2d0/IXmqCr5TVIQ7CL+hTxOziv0IbSQrFf2CCr1tdop6AXAAOhJElNkxI flYo2VwFcSHfP7tJDPkBOfmmqzUh/bkRKPKTYyPiiSUZEtaQqN78SmTxj83UrzoEJ9w6 NMte2MOREbKqk8OkxVzkagyAa+1Uaw1vISH//o7J4RgtucqGedXO+LIAPIEgQrbKqU5+ qatXvvAFQbRl6AXVWUq2NpH29lFW/bvHXljC+2P37th2tPkRwLLGKE18EritjuxYaG+S gRVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727244063; x=1727848863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lDIjHlwQvn0FXZAsTPQMYoaFJJr2KcEtONsfmP4GO8E=; b=e5vTrohRj9o8rtrXdhUzBfmlMmS6jlnLSpUsldTGhyOfyr4TMLfTIlCoakdNCLZOqd 20Rs8kS1iGdGBalh369ec5l1B4OYQXdieSz6oVqIOXadAwKd1VUjHzPbRl5897iOT8CB S5rfQ/NTyUVxw+Mg7wbeIi2ZJkXaBTpOhxMafIH/ZXnv2yRcL4x1jUdIqJNxxlPW4xPJ qZEUzBZ2Wy3//qaFUewzabfLye2O5wuEepMKK2ieHDhkllmwRUVU8UxAWjPpwbTKUqgP /dBwOOhkXDZRYX93bjFDqb4CZwBlll35uonp67ipfXBFaFAMzNjBAX8DKxmJqnGtZtRp VC+w== X-Gm-Message-State: AOJu0YzrLUQVPNntNgGT9+17/rhzkvPlkoGGmIRY4RkOPX7F/ty3Rl8R oZEuPAd6d7yDxfRkjqeT1ij3qtVzpjxtdTd++e36OiuFevdqLWt82QmRJiGrOQ0= X-Google-Smtp-Source: AGHT+IHZwuigQLC9/i5kjyUilLTmxOseUudei026p8CeWIB4nZ1LOhmcx8Tv0ht7FBFnyE9PwNTDmQ== X-Received: by 2002:a5d:64e5:0:b0:371:8dcc:7f9e with SMTP id ffacd0b85a97d-37cc246b10amr1266080f8f.2.1727244063406; Tue, 24 Sep 2024 23:01:03 -0700 (PDT) Received: from [172.20.13.88] ([45.147.210.162]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc32b70fsm3037184f8f.117.2024.09.24.23.01.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 23:01:02 -0700 (PDT) Message-ID: Date: Wed, 25 Sep 2024 00:01:01 -0600 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] struct filename, io_uring and audit troubles To: Al Viro Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org References: <20240922004901.GA3413968@ZenIV> <20240923015044.GE3413968@ZenIV> <62104de8-6e9a-4566-bf85-f4c8d55bdb36@kernel.dk> <20240923144841.GA3550746@ZenIV> <20240923203659.GD3550746@ZenIV> <20240924214046.GG3550746@ZenIV> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240924214046.GG3550746@ZenIV> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/24/24 3:40 PM, Al Viro wrote: > On Mon, Sep 23, 2024 at 09:36:59PM +0100, Al Viro wrote: > >> * go through the VFS side of things and make sure we have a consistent >> set of helpers that would take struct filename * - *not* the ad-hoc mix we >> have right now, when that's basically driven by io_uring borging them in >> one by one - or duplicates them without bothering to share helpers. >> E.g. mkdirat(2) does getname() and passes it to do_mkdirat(), which >> consumes the sucker; so does mknodat(2), but do_mknodat() is static. OTOH, >> path_setxattr() does setxattr_copy(), then retry_estale loop with >> user_path_at() + mnt_want_write() + do_setxattr() + mnt_drop_write() + path_put() >> as a body, while on io_uring side we have retry_estale loop with filename_lookup() + >> (io_uring helper that does mnt_want_write() + do_setxattr() + mnt_drop_write()) + >> path_put(). >> Sure, that user_path_at() call is getname() + filename_lookup() + putname(), >> so they are equivalent, but keeping that shite in sync is going to be trouble. > > BTW, re mess around xattr: > static int __io_getxattr_prep(struct io_kiocb *req, > const struct io_uring_sqe *sqe) > { > ... > ix->ctx.cvalue = u64_to_user_ptr(READ_ONCE(sqe->addr2)); > ix->ctx.size = READ_ONCE(sqe->len); > ... > ret = strncpy_from_user(ix->ctx.kname->name, name, > sizeof(ix->ctx.kname->name)); > > } > > int io_fgetxattr(struct io_kiocb *req, unsigned int issue_flags) > { > ... > ret = do_getxattr(file_mnt_idmap(req->file), > req->file->f_path.dentry, > &ix->ctx); > ... > } > > ssize_t > do_getxattr(struct mnt_idmap *idmap, struct dentry *d, > struct xattr_ctx *ctx) > { > ... > if (error > 0) { > if (ctx->size && copy_to_user(ctx->value, ctx->kvalue, error)) > ... > } > > and we have > struct xattr_ctx { > /* Value of attribute */ > union { > const void __user *cvalue; > void __user *value; > }; > ... > } > > Undefined behaviour aside, there's something odd going on here: > why do we bother with copy-in in ->prep() when we do copy-out in > ->issue() anyway? ->issue() does run with initiator's ->mm in use, > right? > > IOW, what's the io_uring policy on what gets copied in ->prep() vs. > in ->issue()? The normal policy is that anything that is read-only should remain stable after ->prep() has been called, so that ->issue() can use it. That means the application can keep it on-stack as long as it's valid until io_uring_submit() returns. For structs/buffers that are copied to after IO, those the application obviously need to keep around until they see a completion for that request. So yes, for the xattr cases where the struct is copied to at completion time, those do not need to be stable after ->prep(), could be handled purely on the ->issue() side. -- Jens Axboe