From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Cc: linux-hyperv@vger.kernel.org
Subject: Re: [PATCH] mshv_eventfd: convert to CLASS(fd)
Date: Tue, 15 Jul 2025 10:15:01 -0700 [thread overview]
Message-ID: <d3e43b5f-6d2c-4a64-b374-6de98130cb40@linux.microsoft.com> (raw)
In-Reply-To: <20250712165244.GA1880847@ZenIV>
On 7/12/2025 9:52 AM, Al Viro wrote:
> [in viro/vfs.git #work.fd; if nobody objects, into #for-next it goes...]
>
> similar to 66635b077624 ("assorted variants of irqfd setup: convert
> to CLASS(fd)") a year ago...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/drivers/hv/mshv_eventfd.c b/drivers/hv/mshv_eventfd.c
> index 8dd22be2ca0b..48c514da34eb 100644
> --- a/drivers/hv/mshv_eventfd.c
> +++ b/drivers/hv/mshv_eventfd.c
> @@ -377,10 +377,11 @@ static int mshv_irqfd_assign(struct mshv_partition *pt,
> struct eventfd_ctx *eventfd = NULL, *resamplefd = NULL;
> struct mshv_irqfd *irqfd, *tmp;
> unsigned int events;
> - struct fd f;
> int ret;
> int idx;
>
> + CLASS(fd, f)(args->fd);
> +
> irqfd = kzalloc(sizeof(*irqfd), GFP_KERNEL);
> if (!irqfd)
> return -ENOMEM;
> @@ -390,8 +391,7 @@ static int mshv_irqfd_assign(struct mshv_partition *pt,
> INIT_WORK(&irqfd->irqfd_shutdown, mshv_irqfd_shutdown);
> seqcount_spinlock_init(&irqfd->irqfd_irqe_sc, &pt->pt_irqfds_lock);
>
> - f = fdget(args->fd);
> - if (!fd_file(f)) {
> + if (fd_empty(f)) {
> ret = -EBADF;
> goto out;
> }
> @@ -496,12 +496,6 @@ static int mshv_irqfd_assign(struct mshv_partition *pt,
> mshv_assert_irq_slow(irqfd);
>
> srcu_read_unlock(&pt->pt_irq_srcu, idx);
> - /*
> - * do not drop the file until the irqfd is fully initialized, otherwise
> - * we might race against the POLLHUP
> - */
> - fdput(f);
> -
> return 0;
>
> fail:
> @@ -514,8 +508,6 @@ static int mshv_irqfd_assign(struct mshv_partition *pt,
> if (eventfd && !IS_ERR(eventfd))
> eventfd_ctx_put(eventfd);
>
> - fdput(f);
> -
> out:
> kfree(irqfd);
> return ret;
Looks fine to me, thanks.
Reviewed-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
prev parent reply other threads:[~2025-07-15 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 16:52 [PATCH] mshv_eventfd: convert to CLASS(fd) Al Viro
2025-07-15 1:51 ` Wei Liu
2025-07-15 17:15 ` Nuno Das Neves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3e43b5f-6d2c-4a64-b374-6de98130cb40@linux.microsoft.com \
--to=nunodasneves@linux.microsoft.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).