linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: <ntfs3@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Compression fixes for ntfs3
Date: Thu, 20 Nov 2025 09:41:28 +0100	[thread overview]
Message-ID: <d41f1c70-32d6-40ed-963a-888916176906@paragon-software.com> (raw)
In-Reply-To: <20250718195400.1966070-1-willy@infradead.org>

On 7/18/25 21:53, Matthew Wilcox (Oracle) wrote:

> Hi Konstantin,
>
> I found three problems with the NTFS (de)compression code.  The
> first two are simple inefficiencies; there's no need to kmap these
> pages.  The third looks like a potential data corruption (description
> in the patch).  I've marked the third one for backport.
>
> I haven't tested any of this; it could be that my analysis is wrong.
>
> Matthew Wilcox (Oracle) (3):
>    ntfs: Do not kmap pages used for reading from disk
>    ntfs: Do not kmap page cache pages for compression
>    ntfs: Do not overwrite uptodate pages
>
>   fs/ntfs3/frecord.c | 50 +++++++++++++++++++++++++++-------------------
>   1 file changed, 29 insertions(+), 21 deletions(-)
>
Hello,

Thanks for the patches. They have been applied and will go out with the
next pull request.

Regards,
Konstantin


      parent reply	other threads:[~2025-11-20  8:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 19:53 [PATCH 0/3] Compression fixes for ntfs3 Matthew Wilcox (Oracle)
2025-07-18 19:53 ` [PATCH 1/3] ntfs: Do not kmap pages used for reading from disk Matthew Wilcox (Oracle)
2025-07-18 19:53 ` [PATCH 2/3] ntfs: Do not kmap page cache pages for compression Matthew Wilcox (Oracle)
2025-07-18 19:53 ` [PATCH 3/3] ntfs: Do not overwrite uptodate pages Matthew Wilcox (Oracle)
2025-11-20  8:41 ` Konstantin Komarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d41f1c70-32d6-40ed-963a-888916176906@paragon-software.com \
    --to=almaz.alexandrovich@paragon-software.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).