From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98071C4320E for ; Fri, 27 Aug 2021 03:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72F1E60E0B for ; Fri, 27 Aug 2021 03:22:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244142AbhH0DXO (ORCPT ); Thu, 26 Aug 2021 23:23:14 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:32690 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S243968AbhH0DXO (ORCPT ); Thu, 26 Aug 2021 23:23:14 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AdJlzS6DX1wrl1s/lHemQ55DYdb4zR+YMi2TD?= =?us-ascii?q?tnoBLSC9F/b0qynAppomPGDP4gr5NEtApTniAtjkfZq/z+8X3WB5B97LMzUO01?= =?us-ascii?q?HYTr2Kg7GD/xTQXwX69sN4kZxrarVCDrTLZmRSvILX5xaZHr8brOW6zA=3D=3D?= X-IronPort-AV: E=Sophos;i="5.84,355,1620662400"; d="scan'208";a="113546519" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Aug 2021 11:22:23 +0800 Received: from G08CNEXMBPEKD04.g08.fujitsu.local (unknown [10.167.33.201]) by cn.fujitsu.com (Postfix) with ESMTP id 821B24D0D4BA; Fri, 27 Aug 2021 11:22:23 +0800 (CST) Received: from G08CNEXCHPEKD09.g08.fujitsu.local (10.167.33.85) by G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 27 Aug 2021 11:22:24 +0800 Received: from [192.168.22.65] (10.167.225.141) by G08CNEXCHPEKD09.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.23 via Frontend Transport; Fri, 27 Aug 2021 11:22:22 +0800 Subject: Re: [PATCH v7 3/8] fsdax: Replace mmap entry in case of CoW To: Christoph Hellwig , Dan Williams CC: "Darrick J. Wong" , linux-xfs , david , linux-fsdevel , Linux Kernel Mailing List , Linux NVDIMM , Goldwyn Rodrigues , Al Viro , Matthew Wilcox , Goldwyn Rodrigues , Ritesh Harjani References: <20210816060359.1442450-1-ruansy.fnst@fujitsu.com> <20210816060359.1442450-4-ruansy.fnst@fujitsu.com> <20210823125715.GA15536@lst.de> From: Shiyang Ruan Message-ID: Date: Fri, 27 Aug 2021 11:22:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210823125715.GA15536@lst.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-yoursite-MailScanner-ID: 821B24D0D4BA.AF7AB X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@fujitsu.com Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2021/8/23 20:57, Christoph Hellwig wrote: > On Thu, Aug 19, 2021 at 03:54:01PM -0700, Dan Williams wrote: >> >> static void *dax_insert_entry(struct xa_state *xas, struct vm_fault *vmf, >> const struct iomap_iter *iter, void >> *entry, pfn_t pfn, >> unsigned long flags) >> >> >>> { >>> + struct address_space *mapping = vmf->vma->vm_file->f_mapping; >>> void *new_entry = dax_make_entry(pfn, flags); >>> + bool dirty = insert_flags & DAX_IF_DIRTY; >>> + bool cow = insert_flags & DAX_IF_COW; >> >> ...and then calculate these flags from the source data. I'm just >> reacting to "yet more flags". > > Except for the overly long line above that seems like a good idea. > The iomap_iter didn't exist for most of the time this patch has been > around. > So should I reuse the iter->flags to pass the insert_flags? (left shift it to higher bits) -- Thanks, Ruan.