From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08217C433FE for ; Tue, 19 Oct 2021 17:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBF34610E5 for ; Tue, 19 Oct 2021 17:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229991AbhJSRZJ (ORCPT ); Tue, 19 Oct 2021 13:25:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34835 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233460AbhJSRZI (ORCPT ); Tue, 19 Oct 2021 13:25:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634664174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOqfmssTkXXiKThwBGVyyHuYXPo6VBVl8UwOszClJ8c=; b=jEY492oJd7AY7/y8QTlIhGBlNI+BUEiasQjdM0FErq1lybRjx6+n8bN6nIDAa3nvv+9S7N ZgaU60tHV7cS1ndpDimaS7ukHf96GNtQ9E7prb9u7OSdP719czbBnDzuISnIJ8IntbUXvp T4scJRR1n+tpCukbdnMmsELOZjJZ9nE= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-qN9JwyreMSeydxru_Dh4Dw-1; Tue, 19 Oct 2021 13:22:53 -0400 X-MC-Unique: qN9JwyreMSeydxru_Dh4Dw-1 Received: by mail-qt1-f198.google.com with SMTP id d21-20020ac800d5000000b002a7ae3ec644so430802qtg.7 for ; Tue, 19 Oct 2021 10:22:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JOqfmssTkXXiKThwBGVyyHuYXPo6VBVl8UwOszClJ8c=; b=4h0vE3FGLT4VvKIxWz3+Gd2tmoDW+0t0XjenOSaadWPfrSQB6f1dvuuSA0TTtaZSxQ 7b8cmaJYUYU+5Z/Q1Nm/WChPMTLu91hpKd0c57NSlxcj/2B3lcHrzuXfHqPh37XpRuUY An9O1+JWnZGmg6VjzfeMVt2Grj/A4rjk1nrNb1GipJtoaN/j/SnKhzEcPCAsFEY+zATo iQGbFM2kXajNlSNeApWUqk+6ssBb13jsHY9c7XXx8No+rJbeMDxipueNdoeWyCmfhmQb EyP9KKBw6itP48ocvNboXiM5IdIow0smLdAGZOp/6i3Yf5v/otT3DY9lCs0t0bqSh8Du dakQ== X-Gm-Message-State: AOAM5317HRe3EVt/5QqXc/mQMk1d0tPn/4vNdgBctPbhVa6t/ERxNKTM kpUkDkpmFQ8ldjplspVEemq6Z1WkCC70RcpbfpKBBeojHxaliO26HGUHtCIivluSiIq8oXV4NCc aa9nrWPqgYP8dnV7KRBLLObtOtA== X-Received: by 2002:ac8:5fc5:: with SMTP id k5mr1372084qta.273.1634664172098; Tue, 19 Oct 2021 10:22:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzp4cr5dV94h+XDRbaJmp+cfMFv4+i32Ye0oINtZE8qF5SrO8m9PjQyUWjQRiUs6vWX+z8ww== X-Received: by 2002:ac8:5fc5:: with SMTP id k5mr1372059qta.273.1634664171906; Tue, 19 Oct 2021 10:22:51 -0700 (PDT) Received: from [192.168.1.3] (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id m66sm8127161qkb.87.2021.10.19.10.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Oct 2021 10:22:51 -0700 (PDT) Message-ID: Subject: Re: [PATCH 03/67] vfs, fscache: Force ->write_inode() to occur if cookie pinned for writeback From: Jeff Layton To: David Howells , linux-cachefs@redhat.com Cc: Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Matthew Wilcox , Alexander Viro , Omar Sandoval , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 19 Oct 2021 13:22:50 -0400 In-Reply-To: <163456866523.2614702.2234665737111683988.stgit@warthog.procyon.org.uk> References: <163456861570.2614702.14754548462706508617.stgit@warthog.procyon.org.uk> <163456866523.2614702.2234665737111683988.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.40.4 (3.40.4-2.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, 2021-10-18 at 15:51 +0100, David Howells wrote: > Use an inode flag, I_PINNING_FSCACHE_WB, to indicate that a cookie is > pinned in use by that inode for the purposes of writeback. > > Pinning is necessary because the in-use pin from the open file is released > before the writeback takes place, but if the resources aren't pinned, the > dirty data can't be written to the cache. > > Signed-off-by: David Howells > --- > > fs/fs-writeback.c | 8 ++++++++ > include/linux/fs.h | 3 +++ > include/linux/fscache.h | 1 + > include/linux/writeback.h | 1 + > 4 files changed, 13 insertions(+) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 81ec192ce067..f3122831c4fe 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1666,6 +1666,13 @@ __writeback_single_inode(struct inode *inode, struct writeback_control *wbc) > > if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) > inode->i_state |= I_DIRTY_PAGES; > + else if (unlikely(inode->i_state & I_PINNING_FSCACHE_WB)) { > + if (!(inode->i_state & I_DIRTY_PAGES)) { > + inode->i_state &= ~I_PINNING_FSCACHE_WB; > + wbc->unpinned_fscache_wb = true; > + dirty |= I_PINNING_FSCACHE_WB; /* Cause write_inode */ > + } > + } IDGI: how would I_PINNING_FSCACHE_WB get set in the first place? > > spin_unlock(&inode->i_lock); > > @@ -1675,6 +1682,7 @@ __writeback_single_inode(struct inode *inode, struct writeback_control *wbc) > if (ret == 0) > ret = err; > } > + wbc->unpinned_fscache_wb = false; > trace_writeback_single_inode(inode, wbc, nr_to_write); > return ret; > } > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 197493507744..336739fed3e9 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2420,6 +2420,8 @@ static inline void kiocb_clone(struct kiocb *kiocb, struct kiocb *kiocb_src, > * Used to detect that mark_inode_dirty() should not move > * inode between dirty lists. > * > + * I_PINNING_FSCACHE_WB Inode is pinning an fscache object for writeback. > + * > * Q: What is the difference between I_WILL_FREE and I_FREEING? > */ > #define I_DIRTY_SYNC (1 << 0) > @@ -2442,6 +2444,7 @@ static inline void kiocb_clone(struct kiocb *kiocb, struct kiocb *kiocb_src, > #define I_CREATING (1 << 15) > #define I_DONTCACHE (1 << 16) > #define I_SYNC_QUEUED (1 << 17) > +#define I_PINNING_FSCACHE_WB (1 << 18) > > #define I_DIRTY_INODE (I_DIRTY_SYNC | I_DIRTY_DATASYNC) > #define I_DIRTY (I_DIRTY_INODE | I_DIRTY_PAGES) > diff --git a/include/linux/fscache.h b/include/linux/fscache.h > index 01558d155799..ba4878b56717 100644 > --- a/include/linux/fscache.h > +++ b/include/linux/fscache.h > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include > > #if defined(CONFIG_FSCACHE) || defined(CONFIG_FSCACHE_MODULE) > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index d1f65adf6a26..2fda288600d3 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -69,6 +69,7 @@ struct writeback_control { > unsigned for_reclaim:1; /* Invoked from the page allocator */ > unsigned range_cyclic:1; /* range_start is cyclic */ > unsigned for_sync:1; /* sync(2) WB_SYNC_ALL writeback */ > + unsigned unpinned_fscache_wb:1; /* Cleared I_PINNING_FSCACHE_WB */ > > /* > * When writeback IOs are bounced through async layers, only the > > -- Jeff Layton