From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 415ED262FC5 for ; Mon, 23 Jun 2025 15:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750693657; cv=none; b=ZElLR601S5sY5Tq34ImRY8ehZQOJx24oSo1XLzo4+j1wG2Jo+HdmHHPDmmO79ne+C2uMBhKKTa8Jy1ydxI6jZU4Fazdgvlt2rfkckSox8hADkFleei9GZQk2ozmUGg6rtV7Ox7WOWE+JtPFV/N5HeAKnypmlME0Lw5xp1+Q8jRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750693657; c=relaxed/simple; bh=k3ZTWi3pH3yUSCx+tVrpUIR2cMh/m8C2mwW9Bu5f6QQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V8smZ1LN6hSNzsxBY2sprYsfX+FBWaKT2sPiLVAWkopcuayWIySVOHt3XAX7PCUpOAb73YDKTsTbqD/B1bAYp4QkEpccNFfFDcGNN8WyMUxqRwF/jnIjT+rECcmOyxKuNrC7nXNxFYSVpp49687RXKg+81XytRk296N4oN+8Y8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qcck/gIU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qcck/gIU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750693654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GiAjHcBAXD9a3mz8FRd2NO1NhckLiGKv82XFpmw/3HY=; b=Qcck/gIUqUZjUUSzUqzW5sBPG68ZCXFhVUWJYSdcGq+vkQiXkdyIQ8Ow2SSn/NUE1wM5xE QJ8WKCuzOF5H/fWCeetkoNnxIc3PtOmPWjvifstlcM3H0OatJe6r4O/lAVYGvKnmhkTCUl aCKf3+VxOw1YpKJ49hoORbIkVgWyK80= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307-jMR40G-SPtKpzONmS2KyFQ-1; Mon, 23 Jun 2025 11:47:32 -0400 X-MC-Unique: jMR40G-SPtKpzONmS2KyFQ-1 X-Mimecast-MFC-AGG-ID: jMR40G-SPtKpzONmS2KyFQ_1750693651 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f7ebfd00so1889903f8f.2 for ; Mon, 23 Jun 2025 08:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750693651; x=1751298451; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GiAjHcBAXD9a3mz8FRd2NO1NhckLiGKv82XFpmw/3HY=; b=asDlooISoUxUOaYWHnCWnvGGcsybee41sFW+wtGqNLxvrq7glyENoDDBwoVIdYBPJM PcVjgNh7roUILzMPH79I4j0p059k1QkNG83UH3LG2b9oAgpkj/wSF4S9oXFpCONjsBi/ 8RTcRxuf60h8/rhU4J8SRDaRxKaKn+q+obdEor1Yu4pw+S+wv+XRWkJ2uVPTR2hF2Zux nfrPmkncH5NoWYpB9gsHmc/2vmGTgRYjq+Q4jSbJlMkZG0eap59OW+tf24r5o6M+KGYR DdcSKS/yNsSTlzQngGJOXYDqeeb1hP3VXBNQ7uCdmEVqhrogDqQtx+VFfC03hBZ27E9n wCmQ== X-Forwarded-Encrypted: i=1; AJvYcCUrkxa9FHxTYBB2CQGV9iks+SMX/r7nk2iq7NhyLV+henDrWf/ixmuF5nMOA9r5frv90BWyCybg7mvpv+Gg@vger.kernel.org X-Gm-Message-State: AOJu0YzzWIJVttIyt51/KWrCk29cJbehTYoZ47Mpbcw6CgY6JMymgas7 7yUNAnkvInejXVhF+kbhjxKlLn1tPHiRHQs09Tnt6pHYoDtxrkePgcFwpACh9HTzaf2auM4+Jqj /LIhUAcilAiWjzr1JmWLiR8sX1zezn6phi+FV7dD9XJh4z8YCSdAwjgHipHK6eYc9fFI= X-Gm-Gg: ASbGncuGIjFQPPJjZCdZZ1F2VCnGCOdCB+mkjwDsrDYGfSBq3FU8hJCM6vqf4AbnsWh TbB75Am4UrniQGOmJDWCtXrfpMhhcjKhxwN0gaBDK7PRrzvoNf9A6hlL69Ovl32O2/Rd4VdfXiK eWrQcLGG5rEwI7+uUNqIIE6jECsrFStEoPqKM5qBh8W1/94Aj553fPkrPKHQ2As1Q7kOjYxxO6W olbZDu0P1CIuonzCZpeAjIpdxjChL+AYAoa0LCncZbtxyH3KmqG7As9rjGJDOaOaH0CwMHCPjtJ wXeiVSRVO0TrlNOilHcIIdx/3+2kur7X1hlQgn+oNO5ZI4IA57Gsh6hPUHigNw3r/M7OWqnEeIE l7/5D/8tGbu64x6z7jz/U9A8z+BD6LuZ556Bo+HbS9cYVsj0aHw== X-Received: by 2002:a05:6000:40da:b0:3a0:b308:8427 with SMTP id ffacd0b85a97d-3a6d13242f0mr9661361f8f.37.1750693650747; Mon, 23 Jun 2025 08:47:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBbzh6rLRiE5JaILdTM7jhp0Rp9pGuiB9PpXQvKHMRuXqyueW+S30S6ZgK14mTl9LJ6P93/g== X-Received: by 2002:a05:6000:40da:b0:3a0:b308:8427 with SMTP id ffacd0b85a97d-3a6d13242f0mr9661316f8f.37.1750693650228; Mon, 23 Jun 2025 08:47:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f1d91bsm9608094f8f.42.2025.06.23.08.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 08:47:28 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 17:47:26 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 16/29] mm: rename __PageMovable() to page_has_movable_ops() To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-17-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.06.25 22:37, Zi Yan wrote: > On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > >> Let's make it clearer that we are talking about movable_ops pages. >> >> Signed-off-by: David Hildenbrand >> --- >> include/linux/migrate.h | 2 +- >> include/linux/page-flags.h | 2 +- >> mm/compaction.c | 7 ++----- >> mm/memory-failure.c | 4 ++-- >> mm/memory_hotplug.c | 8 +++----- >> mm/migrate.c | 8 ++++---- >> mm/page_alloc.c | 2 +- >> mm/page_isolation.c | 10 +++++----- >> 8 files changed, 19 insertions(+), 24 deletions(-) >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index 204e89eac998f..c575778456f97 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -115,7 +115,7 @@ static inline void __SetPageMovable(struct page *page, >> static inline >> const struct movable_operations *page_movable_ops(struct page *page) >> { >> - VM_BUG_ON(!__PageMovable(page)); >> + VM_BUG_ON(!page_has_movable_ops(page)); >> >> return (const struct movable_operations *) >> ((unsigned long)page->mapping - PAGE_MAPPING_MOVABLE); >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index 4fe5ee67535b2..c67163b73c5ec 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -750,7 +750,7 @@ static __always_inline bool __folio_test_movable(const struct folio *folio) >> PAGE_MAPPING_MOVABLE; >> } >> >> -static __always_inline bool __PageMovable(const struct page *page) >> +static __always_inline bool page_has_movable_ops(const struct page *page) >> { >> return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) == >> PAGE_MAPPING_MOVABLE; >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 5c37373017014..f8b7c09e2e48c 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -1056,11 +1056,8 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, >> * Skip any other type of page >> */ >> if (!PageLRU(page)) { >> - /* >> - * __PageMovable can return false positive so we need >> - * to verify it under page_lock. >> - */ >> - if (unlikely(__PageMovable(page)) && >> + /* Isolation will grab the page lock. */ > > I feel that the removed comment should stay, since the current comment > makes no sense when I read it alone. Well, talking about the page lock is moot either way. The thing is, anything can change while we don't hold a page reference. So should we change the comment to /* isolation code will deal with any races. */ ... or drop it completely? > > In addition, why is __PageMovable() is renamed to page_has_movable_ops() but > __SetPageMovable() stays the same? page_has_movable_ops() and __SetPageMovable() > are functions for checking and setting PAGE_MAPPING_MOVABLE. The naming just > does not look symmetric. See follow-up commits where __SetPageMovable() is cleaned up. -- Cheers, David / dhildenb