linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Pinto <danielpinto52@gmail.com>
To: Kari Argillander <kari.argillander@gmail.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] fs/ntfs3: Fix and rename hidedotfiles mount option
Date: Mon, 10 Oct 2022 12:50:42 +0100	[thread overview]
Message-ID: <d67639e4-565f-e30a-eef8-da28fc5bca8d@gmail.com> (raw)
In-Reply-To: <CAKBF=ps4CUA3crkzUUn8J-0WC-6bGb3Z9PPugzebTajGJ+=rSA@mail.gmail.com>

Às 09:08 de 09/10/22, Kari Argillander escreveu:
> On Fri, 7 Oct 2022 at 15:32, Daniel Pinto <danielpinto52@gmail.com> wrote:
>>
>> The current implementation of the hidedotfiles has some problems, namely:
>>  - there is a bug where enabling it actually disables it and vice versa
>>  - it only works when creating files, not when moving or renaming them
>>  - is is not listed in the enabled options list by the mount command
>>  - its name differs from the equivalent hide_dot_files mount option
>>    used by NTFS-3G, making it incompatible with it for no reason
>>
>> This series of patches tries to fix those problems.
> 
> While you are fixing this can you also make patch to add documentation
> for this mount option. I also think we really should not make new mount
> option names so I would vote hide_dot_files name as you did. We still have
> time for this change as this is not yet in upstream.
> 

I have submitted a v2 of the patch which includes a commit with the
documentation.

>> Daniel Pinto (4):
>>   fs/ntfs3: fix hidedotfiles mount option by reversing behaviour
>>   fs/ntfs3: make hidedotfiles mount option work when renaming files
>>   fs/ntfs3: add hidedotfiles to the list of enabled mount options
>>   fs/ntfs3: rename hidedotfiles mount option to hide_dot_files
>>
>>  fs/ntfs3/frecord.c | 9 +++++++++
>>  fs/ntfs3/inode.c   | 2 +-
>>  fs/ntfs3/super.c   | 6 ++++--
>>  3 files changed, 14 insertions(+), 3 deletions(-)
>>
> 

      parent reply	other threads:[~2022-10-10 11:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 12:32 [PATCH 0/4] fs/ntfs3: Fix and rename hidedotfiles mount option Daniel Pinto
2022-10-07 12:36 ` [PATCH 1/4] fs/ntfs3: fix hidedotfiles mount option by reversing, behaviour Daniel Pinto
2022-10-07 12:38 ` [PATCH 2/4] fs/ntfs3: make hidedotfiles mount option work when renaming files Daniel Pinto
2022-10-07 12:40 ` [PATCH 3/4] fs/ntfs3: add hidedotfiles to the list of enabled mount options Daniel Pinto
2022-10-07 12:43 ` [PATCH 4/4] fs/ntfs3: rename hidedotfiles mount option to hide_dot_files Daniel Pinto
     [not found] ` <CAKBF=ps4CUA3crkzUUn8J-0WC-6bGb3Z9PPugzebTajGJ+=rSA@mail.gmail.com>
2022-10-10 11:50   ` Daniel Pinto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d67639e4-565f-e30a-eef8-da28fc5bca8d@gmail.com \
    --to=danielpinto52@gmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=kari.argillander@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).