From: "Yin, Fengwei" <fengwei.yin@intel.com>
To: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>
Cc: Yujie Liu <yujie.liu@intel.com>,
Oliver Sang <oliver.sang@intel.com>, <oe-lkp@lists.linux.dev>,
<lkp@intel.com>, <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Guo Xuenan <guoxuenan@huawei.com>,
<linux-fsdevel@vger.kernel.org>, <ying.huang@intel.com>,
<feng.tang@intel.com>
Subject: Re: [linus:master] [readahead] ab4443fe3c: vm-scalability.throughput -21.4% regression
Date: Sun, 10 Mar 2024 14:41:42 +0800 [thread overview]
Message-ID: <d7ab3fd4-6c7a-4ff9-a870-535af51256e5@intel.com> (raw)
In-Reply-To: <ZeoFQnVYLLBLNL6J@casper.infradead.org>
Hi Matthew,
On 3/8/2024 2:19 AM, Matthew Wilcox wrote:
> /* Align with smaller pages if needed */
> if (index & ((1UL << order) - 1))
> order = __ffs(index);
> + /* Avoid wrap */
> + if (index + (1UL << order) == 0)
> + order--;
> /* Don't allocate pages past EOF */
> - while (index + (1UL << order) - 1 > limit)
> + while (index + (1UL << order) - 1 > last)
The lockup is related with this line. When index == (last + 1),
deadloop here.
Regards
Yin, Fengwei
> order--;
next prev parent reply other threads:[~2024-03-10 6:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 8:25 [linus:master] [readahead] ab4443fe3c: vm-scalability.throughput -21.4% regression kernel test robot
2024-02-21 11:14 ` Jan Kara
2024-02-22 1:32 ` Oliver Sang
2024-02-22 11:50 ` Jan Kara
2024-02-22 18:37 ` Jan Kara
2024-03-04 4:59 ` Yujie Liu
2024-03-04 5:35 ` Yin, Fengwei
2024-03-06 5:36 ` Yin Fengwei
2024-03-07 9:23 ` Jan Kara
2024-03-07 18:19 ` Matthew Wilcox
2024-03-08 8:37 ` Yujie Liu
2024-03-10 6:41 ` Yin, Fengwei [this message]
2024-03-10 6:40 ` Yin, Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7ab3fd4-6c7a-4ff9-a870-535af51256e5@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@intel.com \
--cc=guoxuenan@huawei.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).