From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE70212B0A for ; Tue, 15 Jul 2025 14:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752589015; cv=none; b=f1aLaAaQmQnFXMgXqPaQJqy4mTqJ+PiHWgiRR3QF1RWHgoT/AiYlZ/jnOCY+S3lXvxuuEsNWg0/tDMn7bM2Dtf0gs1T9l+0+j/Yz9KuTlVk8ZsuE/lqo7O/2rdsEcmQk8JOai2Tl3vXqvtY/baZZkOEwTpHufDRJCFLE/z1h2wY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752589015; c=relaxed/simple; bh=EeCCPvYaO/vZ02CLQpqwrR7TomDQ+vhuMVSKzhcc0jg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KmJRbMbLUu2qdmSiiczdt2ytPyIrgg0O+sCr6t02qkqB43Qj9e0XKR9l0a3GbvHLg5eGHBDZTv1az4o74FDufWFsJ4fMTKeTN3vdA2mCHq4541wKYLAYLlvRx0UK3LrF+a+Q33jQ3A0xDYUldaDXXhQJPVGOgSQDaVe4Pa3W5l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fenet4sW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fenet4sW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752589013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xtUFd8jIZdacMgVpErwt3tqjgeqdKXPmgyL5wbxQy4k=; b=fenet4sWzlha7+WRjXiUamx8KsleobFmvJT3QCUIVOHWzMPOevdvva493C3u9pYth6O27c zw0xUGnOo9O3aePJ4Pw0hXer/BDwdbP1xNgVSCoNMjOcUMrmXDPgW39bysni5Rgj5ReaPB /NVMRPdYWEjRfpT8EfVtBWg4FKfRbuo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-JYpBHUKLPxi4xL7u-HYT1Q-1; Tue, 15 Jul 2025 10:16:51 -0400 X-MC-Unique: JYpBHUKLPxi4xL7u-HYT1Q-1 X-Mimecast-MFC-AGG-ID: JYpBHUKLPxi4xL7u-HYT1Q_1752589011 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4560b81ff9eso20372215e9.1 for ; Tue, 15 Jul 2025 07:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752589010; x=1753193810; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xtUFd8jIZdacMgVpErwt3tqjgeqdKXPmgyL5wbxQy4k=; b=WeJnQlJ//COYVBy0o0tG9HaIclWpPj5DmOxDakXycahVm4au6+ZUojTqtVDDSDDWMT n14kQ6L4RB5g19GDfosLLiF9NHXxtBtltO4ehvWB7pDQO7JUpbwAf9EkEQYx0nq3VgWV l8fneZNS2yXC9m+pn2wRlqTrtHOck7AJ6sAU0dRJySXfXaA8pU8WL3u9Oq2UzyOD1G1J GBsHxzRqDvT7dfXUndfe4RinCjsrFCRvOkFUesU798ieKBXLMutEzFM9UpLcc4HQz+4d AKfOlhzN/OqVYklL/5V76mu0Cdbgt5f9Zv4UVmRwwpvUw9ez+08u4GDH3QbcE0n/KpXE P6+w== X-Forwarded-Encrypted: i=1; AJvYcCXiVvcynRFgaQbyfPsomRoaOCK//D5Z4TVbW2crKHICy2whMWaH5LEcAju7m2edKwfgCF9IRE0o94sgKyHc@vger.kernel.org X-Gm-Message-State: AOJu0YwAvxqwnAQMyvvVP68oGOzzE51BJyOaBdJBCU5E7CTrIjrmBxxt 5ZjQdZ7FKnOtC6DUMu4/0LqtqfdDevKAvqT+C01sQXvJR6z+iSGOdj7iCIHxhI34ywdS17SS4Nh +mu8evNRVPSajIHzkbAzigy8nY01U/iS76TpiWusfErsRGCN45wLLARlJ6BtjGLrwDiI= X-Gm-Gg: ASbGncsW0e+1aHfyICZI4i1+bzUj4Wdw6eQ5ebwFHwj3/f9s8hZIixTjc9WcKyNZnQy gTeNc3d7MnWJjosUrBM8CfKYSeFh634m1J4pcapcGNaTp2bBLSr8lImssllEKr1dag5siyt8dw5 lnfjzrvDs81DFF/g8QDR0rKe9YubQ0eQoymEs2XQaMM5WsKDopKCdV30oe9a3u6qtiCq9PigH/G R1FH5EqkUr9JWXH40PTSqiWpRgG7qPdd5KBWy6t/4ACjJcFlzGTq9tF6mtVK5VP0jLil9I1YZWk rq/AwHjU1ThwCZbpMpid0eR77eOsgngfDZmYl2GitGt2GDzdjm0M3Pm8+EDwIpYeDigvxQYm3qd egG5DSKRKMQCMVE2/EvFDlU7x8HWV6mtvm6OVA0E0nT+2QEhPJRw2aCIpYGL+DkL7fMA= X-Received: by 2002:a05:6000:2283:b0:3a5:8600:7cff with SMTP id ffacd0b85a97d-3b5f1875938mr14092722f8f.1.1752589009225; Tue, 15 Jul 2025 07:16:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtF3aNyi3pbj6yCkk1zAFYxYfd7ezRbzUP3crF9cjiRso9uL/U1MBxt8As/NbiPD2fcAEmzQ== X-Received: by 2002:a05:6000:2283:b0:3a5:8600:7cff with SMTP id ffacd0b85a97d-3b5f1875938mr14092465f8f.1.1752589006625; Tue, 15 Jul 2025 07:16:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:4900:2c24:4e20:1f21:9fbd? (p200300d82f2849002c244e201f219fbd.dip0.t-ipconnect.de. [2003:d8:2f28:4900:2c24:4e20:1f21:9fbd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8bd1a2bsm15527533f8f.14.2025.07.15.07.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Jul 2025 07:16:46 -0700 (PDT) Message-ID: Date: Tue, 15 Jul 2025 16:16:44 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] add static PMD zero page support To: Lorenzo Stoakes Cc: Pankaj Raghav , Zi Yan , Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Mike Rapoport , Dave Hansen , Michal Hocko , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav References: <20250707142319.319642-1-kernel@pankajraghav.com> From: David Hildenbrand Content-Language: en-US Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.07.25 16:12, Lorenzo Stoakes wrote: > On Tue, Jul 15, 2025 at 04:06:29PM +0200, David Hildenbrand wrote: >> I think at some point we discussed "when does the PMD-sized zeropage make >> *any* sense on these weird arch configs" (512MiB on arm64 64bit) >> >> No idea who wants to waste half a gig on that at runtime either. > > Yeah this is a problem we _really_ need to solve. But obviously somewhat out of > scope here. > >> >> But yeah, we should let the arch code opt in whether it wants it or not (in >> particular, maybe only on arm64 with CONFIG_PAGE_SIZE_4K) > > I don't think this should be an ARCH_HAS_xxx. > > Because that's saying 'this architecture has X', this isn't architecture > scope. > > I suppose PMDs may vary in terms of how huge they are regardless of page > table size actually. > > So maybe the best solution is a semantic one - just rename this to > ARCH_WANT_STATIC_PMD_ZERO_PAGE > > And then put the page size selector in the arch code. > > For example in arm64 we have: > > select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > > So doing something similar here like: > > select ARCH_WANT_STATIC_PMD_ZERO_PAGE if ARM64_4K_PAGES > > Would do thie job and sort everything out. Yes. -- Cheers, David / dhildenb