Re: [PATCH v2 03/10] ext4: drop ext4_update_disksize_before_punch()

[Zhang Yi <yi.zhang@huaweicloud.com>]

On 2024/9/24 18:11, Jan Kara wrote:
> On Tue 24-09-24 15:43:22, Zhang Yi wrote:
>> On 2024/9/21 0:13, Jan Kara wrote:
>>> On Wed 04-09-24 14:29:18, Zhang Yi wrote:
>>>> From: Zhang Yi <yi.zhang@huawei.com>
>>>>
>>>> Since we always write back dirty data before zeroing range and punching
>>>> hole, the delalloc extended file's disksize of should be updated
>>>> properly when writing back pages, hence we don't need to update file's
>>>> disksize before discarding page cache in ext4_zero_range() and
>>>> ext4_punch_hole(), just drop ext4_update_disksize_before_punch().
>>>>
>>>> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
>>>
>>> So when we don't write out before hole punching & company this needs to stay
>>> in some shape or form. 
>>>
>>
>> Thanks for taking time to review this series!
>>
>> I don't fully understand this comment, please let me confirm. Do you
>> suggested that we still don't write out all the data before punching /
>> zeroing / collapseing(i.e. drop patch 01), so we need to keep
>> ext4_update_disksize_before_punch()(i.e. also drop this patch), is
>> that right?
> 
> Yes, this is what I meant. Sorry for not being clear.
> 
> 								Honza
> 

OK, this looks fine to me. Let me revise this series.

Thanks,
Yi.